[
https://issues.apache.org/jira/browse/DISPATCH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940991#comment-16940991
]
ASF GitHub Bot commented on DISPATCH-1426:
------------------------------------------
kgiusti commented on pull request #573: DISPATCH-1426 - Added an abandoned
deliveries handler so all abandone…
URL: https://github.com/apache/qpid-dispatch/pull/573#discussion_r329594071
##########
File path: src/router_node.c
##########
@@ -102,8 +102,8 @@ static qdr_delivery_t
*qdr_node_delivery_qdr_from_pn(pn_delivery_t *dlv)
}
-static void qdr_node_reap_abandoned_deliveries(qdr_core_t *core, qd_link_t
*link)
-{
+void qd_link_abandoned_deliveries_handler(void *context, qd_link_t *link) {
Review comment:
Nit: Add a newline after the parameter list: the opening brace should be on
the next line by itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Repetitive receiver fail over causes memory leak
> ------------------------------------------------
>
> Key: DISPATCH-1426
> URL: https://issues.apache.org/jira/browse/DISPATCH-1426
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.8.0, 1.9.0
> Reporter: Ken Giusti
> Assignee: Ganesh Murthy
> Priority: Major
>
> I'm able to cause a slow memory leak by running a new test I'm creating for
> reproducing [DISPATCH-1406|https://github.com/apache/qpid-dispatch/pull/564]
> test for an extended time. Output of qdstat -m after test run:
> {{$ qdstat -m -b 127.0.0.1:22381
> Types
> type size batch thread-max total in-threads
> rebal-in rebal-out
>
> ==============================================================================================
> qd_bitmask_t 24 64 128 576 448 1
> 3
> qd_buffer_t 536 64 128 2,240 2,240 8
> 8
> qd_composed_field_t 64 64 128 256 256 0
> 0
> qd_composite_t 112 64 128 320 320 0
> 0
> qd_connection_t 2,360 16 32 48 48 0
> 0
> qd_connector_t 504 64 128 64 64 0
> 0
> qd_hash_handle_t 16 64 128 128 128 0
> 0
> qd_hash_item_t 32 64 128 128 128 0
> 0
> qd_iterator_t 160 64 128 4,224 4,224 4
> 4
> qd_link_ref_t 24 64 128 320 192 0
> 2
> qd_link_t 104 64 128 192 192 0
> 0
> qd_listener_t 440 64 128 64 64 0
> 0
> qd_log_entry_t 2,112 16 32 1,056 1,056 0
> 0
> qd_management_context_t 56 64 128 128 128 0
> 0
> qd_message_content_t 1,080 64 128 576 576 0
> 0
> qd_message_t 160 64 128 768 704 2
> 3
> qd_node_t 56 64 128 64 64 0
> 0
> qd_parse_node_t 104 64 128 128 128 0
> 0
> qd_parsed_field_t 88 64 128 1,664 1,664 0
> 0
> qd_parsed_turbo_t 64 64 128 256 256 0
> 0
> qd_pn_free_link_session_t 32 64 128 64 64 0
> 0
> qd_timer_t 56 64 128 128 128 0
> 0
> qdr_action_t 160 64 128 320 192 24
> 26
> qdr_address_config_t 72 64 128 64 64 0
> 0
> qdr_address_t 376 64 128 64 64 0
> 0
> qdr_connection_info_t 88 64 128 192 192 0
> 0
> qdr_connection_t 568 64 128 192 192 0
> 0
> qdr_connection_work_t 48 64 128 64 64 0
> 0
> qdr_delivery_cleanup_t 32 64 128 384 384 1
> 1
> qdr_delivery_ref_t 24 64 128 256 192 2
> 3
> qdr_delivery_t 272 64 128 640 512 1
> 3
> qdr_error_t 24 64 128 256 256 0
> 0
> qdr_field_t 40 64 128 768 768 0
> 0
> qdr_forward_deliver_info_t 32 64 128 64 64 0
> 0
> qdr_general_work_t 128 64 128 384 384 2
> 2
> qdr_link_ref_t 24 64 128 448 448 0
> 0
> qdr_link_t 512 64 128 256 256 0
> 0
> qdr_link_work_t 48 64 128 448 448 1
> 1
> qdr_node_t 64 64 128 64 64 0
> 0
> qdr_query_t 344 64 128 128 128 0
> 0
> qdr_terminus_t 64 64 128 256 256 0
> 0
> qdtm_router_t 16 64 128 64 64 0
> 0
> }}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
