[
https://issues.apache.org/jira/browse/DISPATCH-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944557#comment-16944557
]
ASF GitHub Bot commented on DISPATCH-1423:
------------------------------------------
codecov-io commented on issue #580: DISPATCH-1423: restore original mcast
credit replenish behavior
URL: https://github.com/apache/qpid-dispatch/pull/580#issuecomment-538425385
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/580?src=pr&el=h1)
Report
> Merging
[#580](https://codecov.io/gh/apache/qpid-dispatch/pull/580?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/15db9bf50e12f003eff97ab0c4ca6ca952510fb8?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/580?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 86.32% 86.32% +<.01%
==========================================
Files 90 90
Lines 20394 20393 -1
==========================================
Hits 17605 17605
+ Misses 2789 2788 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/580?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/580/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.26% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/580/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `66.83% <0%> (-0.51%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/580/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.86% <0%> (ø)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/580/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93% <0%> (ø)` | :arrow_up: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/580/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `90.99% <0%> (+0.09%)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/580/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.51% <0%> (+0.16%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/580?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/580?src=pr&el=footer).
Last update
[15db9bf...e157ae9](https://codecov.io/gh/apache/qpid-dispatch/pull/580?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Multicast sender with no receiver has first 250 messages released
> -----------------------------------------------------------------
>
> Key: DISPATCH-1423
> URL: https://issues.apache.org/jira/browse/DISPATCH-1423
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
> Affects Versions: 1.8.0
> Reporter: Charles E. Rolke
> Assignee: Ken Giusti
> Priority: Major
> Attachments: INTB-250-released-1.8.0.html, INTB.conf
>
>
> When a sender starts and there's no receiver already attached then the first
> 250 messages the sender sends get released. After that the router waits for
> the a receiver to attach before issuing more credit to the sender. The proton
> c++ simple_send and simple receive clients expose this problem.
> 1. Start router with attached config file
> 2. Start sender
> simple_send -a 127.0.0.1:5672/multicast/q1 -m 500
> 3. Start receiver
> simple_recv -a 127.0.0.1:5672/multicast/q1 -m 500
> The sender competes with 'all messages confirmed'.
> The receiver is waiting for the second 250 messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
