[ 
https://issues.apache.org/jira/browse/DISPATCH-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946029#comment-16946029
 ] 

ASF GitHub Bot commented on DISPATCH-1442:
------------------------------------------

bhardesty commented on pull request #581: DISPATCH-1442 - Added annotation 
field to the router entity.
URL: https://github.com/apache/qpid-dispatch/pull/581#discussion_r332123654
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -493,6 +493,12 @@
                     "create": true,
                     "required": false,
                     "default": "balanced"
+                },
+                "annotation": {
+                    "type": "string",
+                    "description": "Annotation text for this router, to be 
used by user or orchestration layers.",
 
 Review comment:
   How about this (I made some assumptions about the primary use case for 
providing an annotation, which may or may not be accurate):
   
   Optional annotation text to describe or label this router. This text does 
not affect the function of the router, but it can be used by external tools 
(such as the console or orchestration software) to control how the router is 
displayed.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add an annotation field to the router management entity
> -------------------------------------------------------
>
>                 Key: DISPATCH-1442
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1442
>             Project: Qpid Dispatch
>          Issue Type: New Feature
>          Components: Management Agent
>            Reporter: Ted Ross
>            Assignee: Ted Ross
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> This improvement adds a new attribute to the router entity called 
> "annotation".  This field is an opaque string that is set during 
> configuration and can be queried or read at any time via the management 
> protocol.
> This field can be used by the user, the console, or controlling orchestration 
> layers to store identifying information about the router instance.
> Examples of the kind of data that can be store in the annotation include but 
> are not limited to:  public cloud availability zone, geographic map 
> coordinates, a user-friendly label, administrative owner, display color, etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to