[
https://issues.apache.org/jira/browse/DISPATCH-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947841#comment-16947841
]
ASF GitHub Bot commented on DISPATCH-1446:
------------------------------------------
codecov-io commented on issue #583: DISPATCH-1446 - Modified get_test_log in
system_tests__qdmanage to no…
URL: https://github.com/apache/qpid-dispatch/pull/583#issuecomment-540086564
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/583?src=pr&el=h1)
Report
> Merging
[#583](https://codecov.io/gh/apache/qpid-dispatch/pull/583?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/eae457593a3f06db0cb0acb8fca8bd3f68cd504e?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/583?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 86.27% 86.27% -0.01%
==========================================
Files 90 90
Lines 20392 20391 -1
==========================================
- Hits 17594 17592 -2
- Misses 2798 2799 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/583?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/583/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `66.83% <0%> (-0.51%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/583/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `88.27% <0%> (-0.2%)` | :arrow_down: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/583/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.46% <0%> (-0.13%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/583/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `90.98% <0%> (-0.01%)` | :arrow_down: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/583/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.73% <0%> (+0.19%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/583/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.01% <0%> (+0.24%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/583?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/583?src=pr&el=footer).
Last update
[eae4575...f7a1343](https://codecov.io/gh/apache/qpid-dispatch/pull/583?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> system_tests_qdmanage failing on test_get_log
> ---------------------------------------------
>
> Key: DISPATCH-1446
> URL: https://issues.apache.org/jira/browse/DISPATCH-1446
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.9.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.10.0
>
>
>
> {noformat}
> ======================================================================
> FAIL: test_get_log (system_tests_qdmanage.QdmanageTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_qdmanage.py", line
> 236, in test_get_log
> self.assertEquals(['AGENT', 'debug'], log[0:2])
> AssertionError: Lists differ: [u'AGENT', u'debug'] != [u'ROUTER', u'trace']
> First differing element 0:
> u'AGENT'
> u'ROUTER'
> - [u'AGENT', u'debug']
> + [u'ROUTER', u'trace']
> ----------------------------------------------------------------------
> Ran 1 test in 16.316s
> FAILED (failures=1)
> [gmurthy@localhost build]$ {noformat}
>
> The test expects the last line of the log to be the AGENT log but sometimes a
> ROUTER log sneaks in. Modify the test to get something like the last 20 lines
> and make sure the AGENT log appears in it.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
