[
https://issues.apache.org/jira/browse/PROTON-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948977#comment-16948977
]
ASF GitHub Bot commented on PROTON-2114:
----------------------------------------
astitcher commented on pull request #194: PROTON-2114:[CMake] Fixing an issue
with cmake not compiling c++11 e…
URL: https://github.com/apache/qpid-proton/pull/194#discussion_r333759956
##########
File path: cpp/examples/CMakeLists.txt
##########
@@ -56,6 +56,18 @@ if (DEFINED CMAKE_CXX_COMPILE_FEATURES)
endif ()
set(CMAKE_CXX_STANDARD ${STD})
set(CMAKE_CXX_EXTENSIONS OFF)
+ else ()
Review comment:
This is indented wrongly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] C++11 examples are not compiled by default
> ------------------------------------------------
>
> Key: PROTON-2114
> URL: https://issues.apache.org/jira/browse/PROTON-2114
> Project: Qpid Proton
> Issue Type: Bug
> Components: build, proton-c
> Environment: RHEL 7.5
> qpid-proton-cpp-docs-0.26.0-1
> cmake 2.8.12.2
> gcc 4.8.5
> g++ 4.8.5
> Reporter: Nicholas Caughey
> Priority: Major
>
> These C++11 examples are not compiled by default:
> * multithreaded_client
> * multithreaded_client_flow_control
> * scheduled_send
> * service_bus
> {{cmake}} is checking CPP11 availability, but it looks that it is not enough
> and then it does not compile C++11 examples.
> But I am able to compile these examples by:
> {{g++ <example_name>.cpp -o <example_name> -lqpid-proton-cpp -std=c++11}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
