[
https://issues.apache.org/jira/browse/PROTON-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949636#comment-16949636
]
ASF GitHub Bot commented on PROTON-2118:
----------------------------------------
astitcher commented on issue #195: PROTON-2118 fix connect_config parsing tests
when jsoncpp < 1.7.0
URL: https://github.com/apache/qpid-proton/pull/195#issuecomment-541146308
Looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> connect_config_test/test_invalid fails with jsoncpp < 1.7.0
> -----------------------------------------------------------
>
> Key: PROTON-2118
> URL: https://issues.apache.org/jira/browse/PROTON-2118
> Project: Qpid Proton
> Issue Type: Test
> Components: cpp-binding
> Affects Versions: proton-c-0.29.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
>
> {noformat}
> 18: Test command: /usr/bin/python
> "/root/rpmbuild/BUILD/qpid-proton-0.29.0/scripts/env.py" "--"
> "PN_SASL_CONFIG_PATH=/root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/testdata/sasl-conf"
> "/root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/connect_config_test"
> 18: Test timeout computed to be: 1500
> 18: TEST: test_default_file()
> 18: TEST: test_addr()
> 18: TEST: test_invalid()
> 18: Error from reader: * Line 1, Column 2
> 18: Missing '}' or object member name
> 18: FAIL test_invalid()
> 18:
> /root/rpmbuild/BUILD/qpid-proton-0.29.0/cpp/src/connect_config_test.cpp:124:
> failed ASSERT_SUBSTRING(("Missing '}'"), e.what()) 'Missing '}'' not found in
> 'connection configuration: reader error'
> 18: TEST: test_default_connect().run()
> 18: TEST: test_almost_default_connect().run()
> 18: TEST: test_host_user_pass().run()
> 18: TEST: test_tls().run()
> 18: TEST: test_tls_default_fail().run()
> 18: TEST: test_tls_external().run()
> 18: TEST: test_tls_plain().run()
> 12/15 Test #18: cpp-connect_config_test ..........***Failed 0.89 sec
> {noformat}
> Seems to be caused by version of jsoncpp older than this commit which went to
> 1.7.0
> https://github.com/open-source-parsers/jsoncpp/commit/6b10ce8c0d07ea07861e82f65f17d9fd6abd658d
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
