[
https://issues.apache.org/jira/browse/DISPATCH-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952943#comment-16952943
]
ASF GitHub Bot commented on DISPATCH-1445:
------------------------------------------
kgiusti commented on pull request #587: DISPATCH-1445 - Modeled saslPassword to
be more or less in line with …
URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335551241
##########
File path: tests/system_tests_sasl_plain.py
##########
@@ -22,15 +22,31 @@
from __future__ import absolute_import
from __future__ import print_function
-import os
-from subprocess import PIPE, Popen
-from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT,
SkipIfNeeded
+import os, json
+from subprocess import PIPE, STDOUT, Popen
+from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT,
SkipIfNeeded, Process
from system_test import unittest
from qpid_dispatch.management.client import Node
from proton import SASL
class RouterTestPlainSaslCommon(TestCase):
+ def run_qdmanage(self, cmd, input=None, expect=Process.EXIT_OK,
Review comment:
We've cut and pasted this code too many times.
See system_test.py - class QdManager(). It wraps qdmanage and exports
operations as methods. See system_tests_edge_router.py for an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update saslPassword attribute in connector entity to use openssl style
> prefixes
> -------------------------------------------------------------------------------
>
> Key: DISPATCH-1445
> URL: https://issues.apache.org/jira/browse/DISPATCH-1445
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Container
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.10.0
>
>
> Modify the saslPassword attribute of the connector entity to use env: file:
> and pass: prefixes. Model this around the sslProfile's password field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
