[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953813#comment-16953813
]
ASF GitHub Bot commented on DISPATCH-1384:
------------------------------------------
kgiusti commented on pull request #590: DISPATCH-1384 - Fix unit_tests
URL: https://github.com/apache/qpid-dispatch/pull/590#discussion_r336044898
##########
File path: CMakeLists.txt
##########
@@ -191,9 +191,13 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
add_compile_options(-Wno-gnu-statement-expression)
endif()
-if (NOT (APPLE OR USE_SANITIZERS OR USE_TSAN))
+if (APPLE)
Review comment:
Just a head's up - I'm refactoring the way we enable TSAN in cmake to follow
the model used by proton.
See [DISPATCH-1450](https://issues.apache.org/jira/browse/DISPATCH-1450)
I'll be creating a pull request for DISPATCH-1450 in the next day or so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix tests in Travis CI on macOS
> -------------------------------
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
> 23 - system_tests_policy (Timeout)
> 28 - system_tests_sasl_plain (Failed)
> 38 - system_tests_auth_service_plugin (Failed)
> 39 - system_tests_authz_service_plugin (Failed)
> 48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
