[
https://issues.apache.org/jira/browse/DISPATCH-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956031#comment-16956031
]
Jiri Daněk commented on DISPATCH-1384:
--------------------------------------
I tried a few things and I came to conclusion that I don't understand what's
breaking isprint(). I could not create a standalone reproducer for this
behavior, I could only see it when running qdrouterd, either started by the
run.py, or also in clion debugger. Regarding solution, the following change in
Proton fixes the affected tests, but I don't really know what exactly I am
fixing.
{noformat}
diff --git a/c/src/core/util.c b/c/src/core/util.c
index 39bea4d9..7f389770 100644
--- a/c/src/core/util.c
+++ b/c/src/core/util.c
@@ -38,7 +38,7 @@ ssize_t pn_quote_data(char *dst, size_t capacity, const char
*src, size_t size)
for (unsigned i = 0; i < size; i++)
{
uint8_t c = src[i];
- if (isprint(c)) {
+ if (c < 128 && isprint(c)) {
if (idx < (int) (capacity - 1)) {
dst[idx++] = c;
} else {
{noformat}
With that, I can get the following result on my machine
{noformat}
97% tests passed, 2 tests failed out of 60
Total Test time (real) = 1340.29 sec
The following tests FAILED:
41 - system_tests_delivery_abort (Failed)
51 - system_tests_edge_router (Timeout)
{noformat}
{noformat}
test 41
Start 41: system_tests_delivery_abort
41: Test command: /Users/cloud-user/repos/qpid/py3venv/bin/python
"/Users/cloud-user/repos/qpid/qpid-dispatch/build/tests/run.py" "-m" "unittest"
"-v" "system_tests_delivery_abort"
41: Test timeout computed to be: 360
41: test_01_message_route_truncated_one_router
(system_tests_delivery_abort.RouterTest) ... ok
41: test_02_message_route_truncated_two_routers
(system_tests_delivery_abort.RouterTest) ... ok
41: test_03_link_route_truncated_one_router
(system_tests_delivery_abort.RouterTest) ... ok
41: test_04_link_route_truncated_two_routers
(system_tests_delivery_abort.RouterTest) ... ok
41: test_05_message_route_abort_one_router
(system_tests_delivery_abort.RouterTest) ... ok
41: test_06_message_route_abort_two_routers
(system_tests_delivery_abort.RouterTest) ... FAIL
41: test_07_multicast_truncate_one_router
(system_tests_delivery_abort.RouterTest) ... ok
41:
41: ======================================================================
41: FAIL: test_06_message_route_abort_two_routers
(system_tests_delivery_abort.RouterTest)
41: ----------------------------------------------------------------------
41: Traceback (most recent call last):
41: File
"/Users/cloud-user/repos/qpid/qpid-dispatch/tests/system_tests_delivery_abort.py",
line 118, in test_06_message_route_abort_two_routers
41: self.assertEqual(None, test.error)
41: AssertionError: None != 'Timeout Expired - Unprocessed Ops: [], R[37
chars]000]'
41:
41: ----------------------------------------------------------------------
41: Ran 7 tests in 14.909s
41:
41: FAILED (failures=1)
41/60 Test #41: system_tests_delivery_abort .......................***Failed
15.16 sec
{noformat}
> Fix tests in Travis CI on macOS
> -------------------------------
>
> Key: DISPATCH-1384
> URL: https://issues.apache.org/jira/browse/DISPATCH-1384
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Labels: macOS
>
> {noformat}
> The following tests FAILED:
> 9 - unit_tests (SEGFAULT)
> 23 - system_tests_policy (Timeout)
> 28 - system_tests_sasl_plain (Failed)
> 38 - system_tests_auth_service_plugin (Failed)
> 39 - system_tests_authz_service_plugin (Failed)
> 48 - system_tests_bad_configuration (Failed)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
