[ 
https://issues.apache.org/jira/browse/DISPATCH-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956202#comment-16956202
 ] 

ASF GitHub Bot commented on DISPATCH-1363:
------------------------------------------

codecov-io commented on issue #592: DISPATCH-1363 - Move RAT licence check from 
travis builds into a sub build
URL: https://github.com/apache/qpid-dispatch/pull/592#issuecomment-543364515
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=h1) 
Report
   > Merging 
[#592](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/2339c41e0e2670894858083cce20cd51caeffa4b?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/592/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #592      +/-   ##
   ==========================================
   - Coverage   86.36%   86.35%   -0.01%     
   ==========================================
     Files          90       90              
     Lines       20484    20483       -1     
   ==========================================
   - Hits        17691    17689       -2     
   - Misses       2793     2794       +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `93.26% <0%> (-0.5%)` | :arrow_down: |
   | 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `93.86% <0%> (-0.12%)` | :arrow_down: |
   | 
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
 | `90.99% <0%> (-0.1%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `93.14% <0%> (+0.12%)` | :arrow_up: |
   | 
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
 | `89.51% <0%> (+0.16%)` | :arrow_up: |
   | 
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/592/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
 | `81.37% <0%> (+0.18%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=footer).
 Last update 
[2339c41...d2930ea](https://codecov.io/gh/apache/qpid-dispatch/pull/592?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Remove apache rat check from main travis build and move to a sub build 
> -----------------------------------------------------------------------
>
>                 Key: DISPATCH-1363
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1363
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: Ganesh Murthy
>            Assignee: Jiri Daněk
>            Priority: Minor
>              Labels: CI/CD
>
> Currently, when a Travis build fails, we are unable to tell if the the 
> failure was due to the rat check failure or due to a system test failure. You 
> have to scroll all the way to the bottom of the build output page to find out 
> if the rat check failed.
> An improvement would be to move the rat check to a sub build so that it is 
> easy to visually identify if the build failure is due to the rat check or 
> system test failure.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to