[
https://issues.apache.org/jira/browse/QPIDJMS-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957713#comment-16957713
]
ASF GitHub Bot commented on QPIDJMS-441:
----------------------------------------
gemmellr commented on issue #32: QPIDJMS-441: add proxy support
URL: https://github.com/apache/qpid-jms/pull/32#issuecomment-545366060
I also disagree with the way the tests are in the latest commit, it isnt
what I was thinking of previously at all and largely needs unwound I think. I
am not looking for a complete duplication of entire tests for largely unrelated
functional areas such as most of the connection and message processing and
failover tests. Definitely not looking to add a minute to the test suite, even
seconds is pushing it for this I think.
I simply wanted to see at least a handful of tests actually exercising the
overall functionality in basic but key situations, e.g establishing an actual
connection to ensure connection creation works at all (seems like still none in
this area for the HTTP case?), plus doing SSL/TLS at all, checking that it
works with failover at all (e.g also verifying the handler supplier is used at
each reconnect), and implicitly through all of these that the factory extension
mechanism for providing the handlers actually gets exercised. That there were
originally no tests covering any of these meant that the overall functionality
could easily have been broken from the start or in future without any
indication. I think Tim's idea of grouping many/most of the tests for this in a
specific class would likely be good. TransportOptionsTest also still needs
updated to reflect the changes made to the options.
While many of the underlying smarts here are in Netty and those bits are
indeed tested in Netty as you say, there needs to be client tests to ensure
that we actually use those bits correctly, that it all works together as
expected now, and that the overall functionality continues to work in the face
of future change in both the client itself and Netty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Using QPID JMS behind a proxy
> -----------------------------
>
> Key: QPIDJMS-441
> URL: https://issues.apache.org/jira/browse/QPIDJMS-441
> Project: Qpid JMS
> Issue Type: Wish
> Components: qpid-jms-client
> Affects Versions: 0.40.0
> Reporter: morten
> Priority: Blocker
>
> I actually did not find a possibility to use the jms qpid client behind a
> proxy. I guess there will be a lot of people who needs to run the library
> behind a proxy. It would be nice to have the possibility to set a proxy
> somehow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
