[
https://issues.apache.org/jira/browse/DISPATCH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962023#comment-16962023
]
ASF GitHub Bot commented on DISPATCH-1453:
------------------------------------------
codecov-io commented on issue #602: DISPATCH-1453 - Fix the code so the correct
error message shows up wh…
URL: https://github.com/apache/qpid-dispatch/pull/602#issuecomment-547126348
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr&el=h1)
Report
> Merging
[#602](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 86.39% 86.38% -0.01%
==========================================
Files 90 90
Lines 20495 20496 +1
==========================================
- Hits 17707 17706 -1
- Misses 2788 2790 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==)
| `92.38% <100%> (+1.09%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.26% <0%> (-0.75%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `90.99% <0%> (-0.4%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.86% <0%> (-0.35%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.34% <0%> (-0.02%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.16% <0%> (+0.11%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.33% <0%> (+0.5%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/602/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.89% <0%> (+0.7%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr&el=footer).
Last update
[d37ee8c...1e5bc9f](https://codecov.io/gh/apache/qpid-dispatch/pull/602?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Adding "defaultDistribution: unavailable" overrides the regular handling of
> transaction coordinator link refusal
> ----------------------------------------------------------------------------------------------------------------
>
> Key: DISPATCH-1453
> URL: https://issues.apache.org/jira/browse/DISPATCH-1453
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.9.0
> Reporter: Robbie Gemmell
> Assignee: Ganesh Murthy
> Priority: Minor
>
> DISPATCH-802 added handling to refuse links to the transaction coordinator
> (which has no address, but is a specific target) if a link route to e.g a
> broker isnt configured (using DISPATCH-195), and help clarify the reasons for
> the refusal.
> DISPATCH-803 was added to provide a way for links to adressses that are
> otherwise unknown to be refused rather than message routed, by setting
> "defaultDistribution: unavailable". This functionality overrides the
> behaviour from DISPATCH-802, making it less clear again why a transaction
> usage attempt has failed.
> From a JMS client trying to create a transacted session, the failure with
> "defaultDistribution: unavailable" config present looks like:
> {noformat}
> javax.jms.JMSException: No route to the destination node [condition =
> qd:no-route-to-dest]
> at
> org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
> at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
> at
> org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
> at org.apache.qpid.jms.JmsSession.<init>(JmsSession.java:172)
> at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
> at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
> {noformat}
> While without it,the router sends a more specific error condition, and so the
> failure normally looks like:
> {noformat}
> javax.jms.JMSException: The router can't coordinate transactions by itself, a
> linkRoute to a coordinator must be configured to use transactions. [condition
> = amqp:precondition-failed]
> at
> org.apache.qpid.jms.provider.ProviderException.toJMSException(ProviderException.java:34)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:80)
> at
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.create(JmsExceptionSupport.java:112)
> at org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:698)
> at
> org.apache.qpid.jms.JmsLocalTransactionContext.begin(JmsLocalTransactionContext.java:140)
> at org.apache.qpid.jms.JmsSession.<init>(JmsSession.java:172)
> at org.apache.qpid.jms.JmsConnection.createSession(JmsConnection.java:316)
> at org.apache.qpid.jms.example.HelloWorld.main(HelloWorld.java:52)
> {noformat}
> It would be nicer if the regular coordinator refusal error condition was sent
> in both cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
