[
https://issues.apache.org/jira/browse/DISPATCH-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963402#comment-16963402
]
ASF GitHub Bot commented on DISPATCH-1409:
------------------------------------------
kgiusti commented on pull request #605: DISPATCH-1409 - Exposed
available-credit and time-of-zero-credit as l…
URL: https://github.com/apache/qpid-dispatch/pull/605#discussion_r340841820
##########
File path: src/router_core/transfer.c
##########
@@ -262,6 +262,7 @@ void qdr_link_flow(qdr_core_t *core, qdr_link_t *link, int
credit, bool drain_mo
action->args.connection.drain = drain_mode;
qdr_action_enqueue(core, action);
+ qdr_record_link_credit(core, link);
Review comment:
Curious - why after the action is enqueued, not before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update qdstat -l output to include the current credit
> -----------------------------------------------------
>
> Key: DISPATCH-1409
> URL: https://issues.apache.org/jira/browse/DISPATCH-1409
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node, Tools
> Affects Versions: 1.8.0
> Reporter: Ken Giusti
> Assignee: Ted Ross
> Priority: Major
> Labels: troubleshooting
>
> The (cap) field in the output of qdstat -l shows the configured capacity for
> the link, not the current credit available/outstanding.
> In order to easily detect credit stalls it would be useful to provide the
> current credit for the link.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
