[
https://issues.apache.org/jira/browse/DISPATCH-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967882#comment-16967882
]
ASF GitHub Bot commented on DISPATCH-1468:
------------------------------------------
codecov-io commented on issue #610: DISPATCH-1468: use string constants instead
of buffered strings
URL: https://github.com/apache/qpid-dispatch/pull/610#issuecomment-550028266
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/610?src=pr&el=h1)
Report
> Merging
[#610](https://codecov.io/gh/apache/qpid-dispatch/pull/610?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/1fafe273a5d7f82cccb6d3a0ce5a8c6a6cef84cc?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `69.23%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/610?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 86.47% 86.46% -0.01%
==========================================
Files 91 91
Lines 20617 20613 -4
==========================================
- Hits 17828 17824 -4
Misses 2789 2789
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/610?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/610/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j)
| `91.47% <69.23%> (-0.46%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/610/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `75.68% <0%> (-0.5%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/610/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `88.33% <0%> (-0.2%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/610/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.34% <0%> (-0.17%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/610/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.33% <0%> (+0.11%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/610/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.3% <0%> (+0.22%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/610/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.02% <0%> (+0.74%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/610?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/610?src=pr&el=footer).
Last update
[1fafe27...0198f52](https://codecov.io/gh/apache/qpid-dispatch/pull/610?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> out-of-bounds array access in qd_entity_refresh_connector
> ---------------------------------------------------------
>
> Key: DISPATCH-1468
> URL: https://issues.apache.org/jira/browse/DISPATCH-1468
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.9.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.10.0
>
>
> Found by AddressSanitizer:
>
> /home/kgiusti/work/qpid-dispatch/src/connection_manager.c:852:5: error:
> ‘memset’ forming offset [1, 4] is out of the bounds [0, 0] of object
> ‘(\{anonymous})’ with type ‘unsi\
> gned char[0]’ [-Werror=array-bounds]
> 852 | memset(state_info, 0, sizeof(state_length));;
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/kgiusti/work/qpid-dispatch/src/connection_manager.c:766:12: note:
> ‘(\{anonymous})’ declared here
> 766 | qd_error_t qd_entity_refresh_connector(qd_entity_t* entity, void *impl)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
