[
https://issues.apache.org/jira/browse/PROTON-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969650#comment-16969650
]
ASF GitHub Bot commented on PROTON-2132:
----------------------------------------
codecov-io commented on issue #203: PROTON-2132 Skip compatibility hacks with
libc++
URL: https://github.com/apache/qpid-proton/pull/203#issuecomment-551314693
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/203?src=pr&el=h1)
Report
> Merging
[#203](https://codecov.io/gh/apache/qpid-proton/pull/203?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/bdf9b1a4a0b3f080387362f7391617199af6b203?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/203?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 81.98% 81.98% +<.01%
==========================================
Files 264 264
Lines 35824 35825 +1
==========================================
+ Hits 29369 29372 +3
+ Misses 6455 6453 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/203?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[cpp/src/ssl\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/203/diff?src=pr&el=tree#diff-Y3BwL3NyYy9zc2xfb3B0aW9ucy5jcHA=)
| `75% <ø> (ø)` | :arrow_up: |
|
[c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/203/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j)
| `82.62% <0%> (-0.07%)` | :arrow_down: |
|
[python/tests/proton\_tests/common.py](https://codecov.io/gh/apache/qpid-proton/pull/203/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9jb21tb24ucHk=)
| `80.05% <0%> (+0.85%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/203?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/203?src=pr&el=footer).
Last update
[bdf9b1a...8422d09](https://codecov.io/gh/apache/qpid-proton/pull/203?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> proton-cpp fails to build with build on clang 9.0 when libc++ is used instead
> of libstdc++
> ------------------------------------------------------------------------------------------
>
> Key: PROTON-2132
> URL: https://issues.apache.org/jira/browse/PROTON-2132
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Affects Versions: proton-c-0.29.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
>
> {noformat}
> [ 56%] Building CXX object
> cpp/CMakeFiles/qpid-proton-cpp.dir/src/terminus.cpp.o
> /home/jdanek/repos/qpid/qpid-proton/cpp/src/ssl_options.cpp:219:16: error:
> alias must point to a defined variable or function
> __attribute__((alias("_ZN6proton18ssl_server_optionsC1ERKNS_15ssl_certificateERKSsS5_NS_3ssl11verify_modeE")));
> ^
> /home/jdanek/repos/qpid/qpid-proton/cpp/src/ssl_options.cpp:221:16: error:
> alias must point to a defined variable or function
> __attribute__((alias("_ZN6proton18ssl_server_optionsC2ERKNS_15ssl_certificateERKSsS5_NS_3ssl11verify_modeE")));
> ^
> /home/jdanek/repos/qpid/qpid-proton/cpp/src/ssl_options.cpp:223:16: error:
> alias must point to a defined variable or function
> __attribute__((alias("_ZN6proton18ssl_client_optionsC1ERKNS_15ssl_certificateERKSsNS_3ssl11verify_modeE")));
> ^
> /home/jdanek/repos/qpid/qpid-proton/cpp/src/ssl_options.cpp:225:16: error:
> alias must point to a defined variable or function
> __attribute__((alias("_ZN6proton18ssl_client_optionsC2ERKNS_15ssl_certificateERKSsNS_3ssl11verify_modeE")));
> ^
> 4 errors generated.
> make[2]: *** [cpp/CMakeFiles/qpid-proton-cpp.dir/build.make:583:
> cpp/CMakeFiles/qpid-proton-cpp.dir/src/ssl_options.cpp.o] Error 1
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
