[
https://issues.apache.org/jira/browse/DISPATCH-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976174#comment-16976174
]
ASF GitHub Bot commented on DISPATCH-1483:
------------------------------------------
codecov-io commented on issue #620: DISPATCH-1483: properly update per-link
delivery statistics
URL: https://github.com/apache/qpid-dispatch/pull/620#issuecomment-554791449
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/620?src=pr&el=h1)
Report
> Merging
[#620](https://codecov.io/gh/apache/qpid-dispatch/pull/620?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/dee4313a30b4e275c0be589ca346780bcd5c8712?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/620?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 86.44% 86.44% +<.01%
==========================================
Files 91 91
Lines 20622 20623 +1
==========================================
+ Hits 17827 17828 +1
Misses 2795 2795
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/620?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/620/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `88.38% <100%> (-0.16%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/620/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.36% <0%> (-0.74%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/620/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.34% <0%> (+0.16%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/620/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.2% <0%> (+0.33%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/620?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/620?src=pr&el=footer).
Last update
[dee4313...c71219b](https://codecov.io/gh/apache/qpid-dispatch/pull/620?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Link counters for dispositions are not incremented for outgoing links
> ---------------------------------------------------------------------
>
> Key: DISPATCH-1483
> URL: https://issues.apache.org/jira/browse/DISPATCH-1483
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.9.0
> Reporter: Ted Ross
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.10.0
>
>
> When transferring messages across a router with the deliveries being accepted
> by the receiver, the deliveries-accepted counter for the _outgoing_ link are
> not incremented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
