[ 
https://issues.apache.org/jira/browse/PROTON-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979604#comment-16979604
 ] 

ASF GitHub Bot commented on PROTON-2140:
----------------------------------------

grs commented on pull request #213: PROTON-2140: Lazy creation of various link 
related objects
URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349303323
 
 

 ##########
 File path: c/src/core/codec.c
 ##########
 @@ -364,37 +364,72 @@ static int pn_data_inspect(void *obj, pn_string_t *dst)
 #define pn_data_hashcode NULL
 #define pn_data_compare NULL
 
-pn_data_t *pn_data(size_t capacity)
+pn_data_t *pni_data(size_t capacity, size_t initial_buffer)
 
 Review comment:
   That is probably just an artefact of the evolution of the patch. Initialy I 
began by allocating an empty buffer rather than 64 bytes, but then went 
further. I'll remove the extra function.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> proton-c has very high memory footprint for links
> -------------------------------------------------
>
>                 Key: PROTON-2140
>                 URL: https://issues.apache.org/jira/browse/PROTON-2140
>             Project: Qpid Proton
>          Issue Type: Improvement
>            Reporter: Gordon Sim
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to