[
https://issues.apache.org/jira/browse/PROTON-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980358#comment-16980358
]
ASF subversion and git services commented on PROTON-2142:
---------------------------------------------------------
Commit 3ac12001c67fd8746c0000d2b3b9153e35d8d24a in qpid-proton-j's branch
refs/heads/master from Robbie Gemmell
[ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=3ac1200 ]
PROTON-2142: use transport error condition in close frame if connection error
not set
> transports closed due to decode error may emit a close frame without error
> condition
> ------------------------------------------------------------------------------------
>
> Key: PROTON-2142
> URL: https://issues.apache.org/jira/browse/PROTON-2142
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: proton-j-0.33.2
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: proton-j-0.33.3
>
>
> When a decode error occurs while processing new input, the related transport
> is closed with the exception, which sets an error condition on the transport.
> Upon further processing of output, the transport emits a close frame.
> If the connection endpoint is bound to the transport at this point, the error
> condition object from the connection endpoint is used when generating the
> close frame, even if it contains no error detail (which it doesn't, unless
> explicitly set by the using code). The close frame emitted which is then
> emitted has no error condition, giving no indication to the peer (or those
> debugging the protocol interactions) of there being a problem or what cause
> it. In this case, sending detail from the transport error condition would be
> far more useful.
> Since the transport and connection form an overall unit in use, the handling
> should be updated to use the connection error condition only if its still
> bound *and populated*, but to otherwise use the transport error condition if
> set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
