[
https://issues.apache.org/jira/browse/DISPATCH-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988889#comment-16988889
]
ASF GitHub Bot commented on DISPATCH-1512:
------------------------------------------
codecov-io commented on issue #639: DISPATCH-1512 - Fixed variable name in for
loop in unmap_all_addresses
URL: https://github.com/apache/qpid-dispatch/pull/639#issuecomment-562164176
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/639?src=pr&el=h1)
Report
> Merging
[#639](https://codecov.io/gh/apache/qpid-dispatch/pull/639?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/5b8502dcc25b553587e1e0d83c8fe53a4c9b7620?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/639?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 86.52% 86.53% +<.01%
==========================================
Files 91 91
Lines 20630 20630
==========================================
+ Hits 17851 17852 +1
+ Misses 2779 2778 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/639?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/639/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.75% <0%> (-0.23%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/639/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.11% <0%> (-0.12%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/639/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.98% <0%> (-0.12%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/639/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.91% <0%> (ø)` | :arrow_up: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/639/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `91.3% <0%> (+0.39%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/639?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/639?src=pr&el=footer).
Last update
[5b8502d...bf4ced0](https://codecov.io/gh/apache/qpid-dispatch/pull/639?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> python checker failing due to wrong variable name
> -------------------------------------------------
>
> Key: DISPATCH-1512
> URL: https://issues.apache.org/jira/browse/DISPATCH-1512
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.10.0
>
>
> {noformat}
> 63: /foo/qpid-dispatch/python/qpid_dispatch_internal/router/node.py:559:44:
> F821 undefined name 'addr'
> 63: self.adapter.unmap_destination(addr, self.maskbit)
> 63: ^
> 63: /foo/qpid-dispatch/python/qpid_dispatch_internal/router/node.py:560:97:
> F821 undefined name 'addr'
> 63: self.log(LOG_DEBUG, "Remote destination %s unmapped from
> router %s" % (self._logify(addr), self.id))
> 63:
> ^
> 63: 2 {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
