[
https://issues.apache.org/jira/browse/QPID-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996594#comment-16996594
]
ASF GitHub Bot commented on QPID-8186:
--------------------------------------
chrisrichardson77 commented on pull request #14: QPID-8186 Use const ref when
catching exceptions
URL: https://github.com/apache/qpid-cpp/pull/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Incorrect exception handling fails to build on GCC 8
> ----------------------------------------------------
>
> Key: QPID-8186
> URL: https://issues.apache.org/jira/browse/QPID-8186
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: qpid-cpp-1.38.0
> Environment: Gentoo x64, GCC 8.1
> Reporter: Chris Richardson
> Assignee: Justin Ross
> Priority: Major
> Fix For: qpid-cpp-1.39.0
>
>
> [ 22%] Building CXX object
> src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:
> In member function ‘bool qpid::sys::SocketAddress::isComparable(const
> qpid::sys::SocketAddress&) const’:
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^~~~~~~~~
> /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14:
> error: catching polymorphic type ‘class qpid::Exception’ by value
> [-Werror=catch-value=]
> } catch (Exception) {
> ^~~~~~~~~
>
>
> these "catch (Exception)" statements would better be const ref, which would
> also fix the build failure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
