[
https://issues.apache.org/jira/browse/DISPATCH-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998356#comment-16998356
]
ASF GitHub Bot commented on DISPATCH-1526:
------------------------------------------
codecov-io commented on issue #647: DISPATCH-1526: fix the core client to
replenish credit correctly
URL: https://github.com/apache/qpid-dispatch/pull/647#issuecomment-566628904
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/647?src=pr&el=h1)
Report
> Merging
[#647](https://codecov.io/gh/apache/qpid-dispatch/pull/647?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/c5597b11bfb555fb67a8492d18855b8c25914938?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/647?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
+ Coverage 86.53% 86.54% +0.01%
==========================================
Files 91 91
Lines 20654 20649 -5
==========================================
- Hits 17872 17870 -2
+ Misses 2782 2779 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/647?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/647/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j)
| `91.79% <100%> (-0.16%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/647/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.09% <0%> (-0.34%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/647/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.34% <0%> (+0.11%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/647/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.35% <0%> (+0.18%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/647/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.65% <0%> (+0.48%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/647/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.17% <0%> (+0.49%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/647?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/647?src=pr&el=footer).
Last update
[c5597b1...d6374c2](https://codecov.io/gh/apache/qpid-dispatch/pull/647?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Local temp address credit growing unpectedly, edge and interior
> ---------------------------------------------------------------
>
> Key: DISPATCH-1526
> URL: https://issues.apache.org/jira/browse/DISPATCH-1526
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Environment: Fedora 28. Two hosts: half the routers running python2.7
> and half running python 3.7
> Reporter: Charles E. Rolke
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.11.0
>
>
> * Running 12-node setup: 4 interior routers in a line, each with two edge
> routers attached.
> * Inject a few million messages into an edge router with receivers placed
> throughout the network.
> After a while some link credit values have grown unreasonably.
> {noformat}
> Dispatch 1.10-rc2, rolke's 12-router network
> After running a few million unsettled multicast through some thousands of
> connectionsA few looks at EB2:
> * One link has 72K in the delay column. ???
> One look at INTD:
> * One temp link has credit of 78K > qdstat -l -b amqp://$EB2_normal
> 2019-12-16 20:11:10.602222 UTC
> EB2Router Links
> type dir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> ===============================================================================================================================================================================
> endpoint out 1 9 local _edge
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 10
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 11
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 32 -
> endpoint out 1 12
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 13
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 100 -
> endpoint out 1 14
> 250 0 0 0 75730 75730 0 0 0 0 0 75730 0
> 0 1 -
> endpoint in 1 15
> 250 0 0 0 75730 75730 0 0 0 0 0 0 0
> 0 74770 -
> endpoint out 75729 151470 mobile multicast/q1 0
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 10 -
> endpoint in 1 151471 mobile multicast/q1 0
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 75731 151474 mobile $management 0
> 250 0 0 0 2 0 0 2 0 0 0 0 0
> 0 250 -
> endpoint out 75731 151475 local temp.HNjvLBWfHt70T2j
> 250 0 0 0 1 1 0 0 0 0 0 0 0
> 0 1 - > qdstat -l -b amqp://$EB2_normal
> 2019-12-16 20:11:18.164060 UTC
> EB2Router Links
> type dir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> ===============================================================================================================================================================================
> endpoint out 1 9 local _edge
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 10
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 11
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 32 -
> endpoint out 1 12
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 13
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 100 -
> endpoint out 1 14
> 250 0 0 0 75731 75731 0 0 0 0 0 75731 0
> 0 1 -
> endpoint in 1 15
> 250 0 0 0 75731 75731 0 0 0 0 0 0 0
> 0 74769 -
> endpoint out 75729 151470 mobile multicast/q1 0
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 10 -
> endpoint in 1 151471 mobile multicast/q1 0
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 75732 151476 mobile $management 0
> 250 0 0 0 2 0 0 2 0 0 0 0 0
> 0 250 -
> endpoint out 75732 151477 local temp.Nl+IGH8UhEW+1zU
> 250 0 0 0 1 1 0 0 0 0 0 0 0
> 0 1 - > qdstat -l -b amqp://$EB2_normal
> 2019-12-16 20:11:29.071773 UTC
> EB2Router Links
> type dir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> ===============================================================================================================================================================================
> endpoint out 1 9 local _edge
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 10
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 11
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 32 -
> endpoint out 1 12
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 1 13
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 100 -
> endpoint out 1 14
> 250 0 0 0 75732 75732 0 0 0 0 0 75732 0
> 0 1 -
> endpoint in 1 15
> 250 0 0 0 75732 75732 0 0 0 0 0 0 0
> 0 74768 -
> endpoint out 75729 151470 mobile multicast/q1 0
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 10 -
> endpoint in 1 151471 mobile multicast/q1 0
> 250 0 0 0 0 0 0 0 0 0 0 0 0
> 0 250 -
> endpoint in 75733 151478 mobile $management 0
> 250 0 0 0 2 0 0 2 0 0 0 0 0
> 0 250 -
> endpoint out 75733 151479 local temp.tNBIGbW2M9QjiyJ
> 250 0 0 0 1 1 0 0 0 0 0 0 0
> 0 1 - > qdstat -l -b amqp://$INTD_normal
> 2019-12-16 20:11:36.407769 UTC
> INTDRouter Links
> type dir conn id id peer class addr
> phs cap pri undel unsett deliv presett psdrop acc rej rel
> mod delay rate stuck cred blkd
>
> ======================================================================================================================================================================================================
> endpoint in 2 9
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> edge-downlink out 2 10 edge ED2
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> endpoint out 2 11 mobile _$qd.edge_addr_tracking
> 0 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 32 -
> endpoint in 2 12 mobile $management
> 0 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> endpoint out 2 13 local temp.GTtfXLohcrP7J9s
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 100 -
> endpoint in 2 14 mobile _$qd.addr_lookup
> 0 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 1 -
> endpoint out 2 15 local temp.m1hS68v3b1M6B7V
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> router-control in 1 16
> 250 0 0 0 18654 18654 0 0 0 0
> 0 0 1 0 250 -
> router-control out 1 17 local qdhello
> 250 0 0 0 15555 15555 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 18
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 19
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 20
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 21
> 250 1 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 22
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 23
> 250 2 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 24
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 25
> 250 3 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 26
> 250 0 0 0 14275922 0 0 464894 0
> 10033683 3777345 0 2 0 250 -
> inter-router out 1 27
> 250 4 0 0 30444 30444 0 0 0 0
> 0 0 2 0 250 -
> inter-router in 1 28
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 29
> 250 5 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 30
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 31
> 250 6 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 32
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 33
> 250 7 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 34
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 35
> 250 8 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router in 1 36
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> inter-router out 1 37
> 250 9 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> endpoint in 3 38
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> edge-downlink out 3 39 edge ED1
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> endpoint out 3 40 mobile _$qd.edge_addr_tracking
> 0 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 32 -
> endpoint in 3 41 mobile $management
> 0 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> endpoint out 3 42 local temp.jSR2sg7CTVLXEaK
> 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 100 -
> endpoint in 3 43 mobile _$qd.addr_lookup
> 0 250 0 0 0 79054 79054 0 0 0 0
> 0 0 0 0 1 -
> endpoint out 3 44 local temp.ckzi8UNhT5qQe4i
> 250 0 0 0 79054 79054 0 0 0 0
> 0 0 0 0 77946 -
> endpoint out 3 79154 mobile multicast/q1
> 0 250 0 0 0 0 0 0 0 0 0
> 0 0 0 0 250 -
> endpoint in 32 79155 mobile $management
> 0 250 0 0 0 2 0 0 2 0 0
> 0 0 0 0 250 -
> endpoint out 32 79156 local temp.XYYPigubCz0IMxD
> 250 0 0 0 1 1 0 0 0 0
> 0 0 0 0 1 -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
