[
https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014707#comment-17014707
]
ASF GitHub Bot commented on DISPATCH-1540:
------------------------------------------
codecov-io commented on issue #658: DISPATCH-1540 - Set the pre-settled flag
appropriately on a delivery …
URL: https://github.com/apache/qpid-dispatch/pull/658#issuecomment-573907457
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr&el=h1)
Report
> Merging
[#658](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr&el=desc)
will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 86.53% 86.57% +0.03%
==========================================
Files 91 91
Lines 20652 20658 +6
==========================================
+ Hits 17872 17884 +12
+ Misses 2780 2774 -6
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.23% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `89.59% <100%> (+0.12%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.95% <0%> (-0.47%)` | :arrow_down: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.56% <0%> (+0.12%)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.97% <0%> (+0.22%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.14% <0%> (+0.24%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.32% <0%> (+0.33%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/658/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `76.17% <0%> (+0.49%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr&el=footer).
Last update
[655145d...1e5d89d](https://codecov.io/gh/apache/qpid-dispatch/pull/658?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> multiframe presettled messages not included in presettled count on downstream
> router
> -------------------------------------------------------------------------------------
>
> Key: DISPATCH-1540
> URL: https://issues.apache.org/jira/browse/DISPATCH-1540
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.10.0
> Reporter: Gordon Sim
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.11.0
>
>
> Set up two routers connected to each other. Attach receiver to one, sender to
> the other and send a large message (such that it is sent as multiple transfer
> frames).
>
> Then look at the inter-router link stats for each router. The downstream
> router (i.e. that to which receiver is attached), does not record the
> delivery as presettled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
