[
https://issues.apache.org/jira/browse/DISPATCH-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015315#comment-17015315
]
ASF GitHub Bot commented on DISPATCH-1532:
------------------------------------------
codecov-io commented on issue #654: DISPATCH-1532 - Reimplemented
mobile-address-synchronization as a cor…
URL: https://github.com/apache/qpid-dispatch/pull/654#issuecomment-574322675
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/654?src=pr&el=h1)
Report
> Merging
[#654](https://codecov.io/gh/apache/qpid-dispatch/pull/654?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/2fcb812e3a7050fe671bb1ca91c7c37e3db56173?src=pr&el=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `89.53%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/654?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 86.52% 86.55% +0.02%
==========================================
Files 91 92 +1
Lines 20652 21000 +348
==========================================
+ Hits 17869 18176 +307
- Misses 2783 2824 +41
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/654?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `85% <ø> (ø)` | :arrow_up: |
|
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
| `85.48% <ø> (ø)` | :arrow_up: |
|
[...core/modules/address\_lookup\_client/lookup\_client.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvYWRkcmVzc19sb29rdXBfY2xpZW50L2xvb2t1cF9jbGllbnQuYw==)
| `92.36% <ø> (ø)` | :arrow_up: |
|
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `93.31% <ø> (ø)` | :arrow_up: |
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `78.69% <ø> (ø)` | :arrow_up: |
|
[src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j)
| `91.83% <ø> (ø)` | :arrow_up: |
|
[...uter\_core/modules/edge\_router/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvY29ubmVjdGlvbl9tYW5hZ2VyLmM=)
| `96.87% <ø> (ø)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `95.17% <100%> (+1.21%)` | :arrow_up: |
|
[src/router\_core/core\_events.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfZXZlbnRzLmM=)
| `100% <100%> (ø)` | :arrow_up: |
|
[src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j)
| `77.65% <100%> (-0.8%)` | :arrow_down: |
| ... and [18
more](https://codecov.io/gh/apache/qpid-dispatch/pull/654/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/654?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/654?src=pr&el=footer).
Last update
[2fcb812...84175fc](https://codecov.io/gh/apache/qpid-dispatch/pull/654?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Reimplement mobile-sync as a core module
> ----------------------------------------
>
> Key: DISPATCH-1532
> URL: https://issues.apache.org/jira/browse/DISPATCH-1532
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.11.0
>
>
> The code in Qpid Dispatch Router currently does mobile address
> synchronization between routers in the Python router module. This has a
> couple of drawbacks in cases where there are large numbers of addresses:
> * The address strings are stored twice: once in the main address lookup
> hash table and again in the Python mobile address module.
> * Address lookup on the Python side is inefficient and has been a bottleneck
> (improved recently by a patch from Gordon Sim).
> * Python processing is single threaded. A large mobile address update can
> cause delays in processing management requests and link-state topology
> maintenance.
> The python router module was intended to be an on-the-side control-plane
> moduel that was not in the critical path for any performance-related
> activities. With large numbers of addresses in a network, synchronizing
> address locations becomes performance-related.
> To address these issues, mobile address synchronization can be moved into a
> core module where it can use and share the same address table that is used by
> the router core for make high speed routing decisions. In the process, it
> will leave the python modules alone to process management requests and
> topology maintenance uninterrupted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
