[ 
https://issues.apache.org/jira/browse/PROTON-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016027#comment-17016027
 ] 

ASF GitHub Bot commented on PROTON-2135:
----------------------------------------

jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently
URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574682625
 
 
   And I just wanted to run leak check with proton-python! :(
   
   OK, so the test registration instances I need to unify looks like this
   
   ```
   macro(add_cpp_test test)
     add_executable (${test} src/${test}.cpp)
     target_link_libraries (${test} qpid-proton-cpp ${PLATFORM_LIBS})
     add_test (NAME cpp-${test}
       COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_EXE_PREFIX_CMD} 
$<TARGET_FILE:${test}> ${ARGN})
   endmacro(add_cpp_test)
   
   add_test (NAME python-test
     COMMAND ${PN_ENV_SCRIPT}
     "PATH=${py_path}" "PYTHONPATH=${py_pythonpath}"
     "SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
     ${TEST_ENV}
     ${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -- ${python_coverage_options} 
"${py_tests}/proton-test")
     
   add_test (NAME python-tox-test
     COMMAND ${PN_ENV_SCRIPT} --
     "PATH=${py_path}"
     "SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
     "SWIG=${SWIG_EXECUTABLE}"
     ${TEST_ENV}
     ${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -m tox)
           
   macro(add_ruby_test script)
   get_filename_component(name ${script} NAME_WE)
   string(REPLACE "_" "-" name "ruby-${name}")
   add_test(
       NAME ${name}
       COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_WRAP_PREFIX_CMD} 
${RUBY_EXECUTABLE} ${script} -v
       ${ARGN})
   endmacro()
     
   add_test (NAME ${test} COMMAND ${PN_ENV_SCRIPT} -- ${test_env} 
${TEST_EXE_PREFIX_CMD} $<TARGET_FILE:${test}> 
"@${CMAKE_CURRENT_BINARY_DIR}/${test}-files")
   
   add_test(NAME c-threaderciser COMMAND ${PN_ENV_SCRIPT} -- ${test_env} 
${TEST_EXE_PREFIX_CMD} $<TARGET_FILE:c-threaderciser>)
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> C, cpp, and fuzz tests do not set TEST_ENV on Linux
> ---------------------------------------------------
>
>                 Key: PROTON-2135
>                 URL: https://issues.apache.org/jira/browse/PROTON-2135
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: build
>    Affects Versions: proton-c-0.29.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>
> % cmake .. -DRUNTIME_CHECK=memcheck
> % ctest -V -N
> {noformat}
> 2: Test command: 
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind 
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet" 
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp" 
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/c-core-test"
>   Test  #2: c-core-test
> 8: Test command: 
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind 
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet" 
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp" 
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode" 
> "@/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode-files"
>   Test  #8: fuzz-message-decode
> {noformat}
> I'd've expected to see the execution wrapped in the env.py script.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to