[
https://issues.apache.org/jira/browse/DISPATCH-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016344#comment-17016344
]
ASF GitHub Bot commented on DISPATCH-1541:
------------------------------------------
codecov-io commented on issue #663: DISPATCH-1541: Sets the presettled flag on
large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#issuecomment-574796328
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr&el=h1)
Report
> Merging
[#663](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/992cf139319bddd72442846583540f52b4e7d193?src=pr&el=desc)
will **increase** coverage by `0.13%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #663 +/- ##
==========================================
+ Coverage 86.47% 86.61% +0.13%
==========================================
Files 92 92
Lines 21022 21027 +5
==========================================
+ Hits 18179 18212 +33
+ Misses 2843 2815 -28
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `90.03% <100%> (+0.62%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.24% <100%> (+0.01%)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.17% <0%> (-0.19%)` | :arrow_down: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.73% <0%> (+0.12%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.35% <0%> (+0.18%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.12% <0%> (+0.22%)` | :arrow_up: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `91.3% <0%> (+0.39%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.9% <0%> (+0.48%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `71.22% <0%> (+0.58%)` | :arrow_up: |
| ... and [3
more](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr&el=footer).
Last update
[992cf13...a2c3ca5](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> released and modified counters can get incremented for presettled deliveries
> ----------------------------------------------------------------------------
>
> Key: DISPATCH-1541
> URL: https://issues.apache.org/jira/browse/DISPATCH-1541
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: Gordon Sim
> Priority: Major
>
> Have two routers with sender on one, receiver on other. Send multi-frame
> presettled messages. Kill both sender and receiver midstream (can't get a
> super simple reproducer as yet) and keep repeating. Eventually may see
> non-zero rel and mod stats on downstream router even though messages are
> presettled.
>
> {noformat}
> routerA
> Router Links
> type dir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> =================================================================================================================================================================================
> inter-router out 1 3
> 2000 0 0 0 104 104 0 0 0 0 0 24
> 0 0 250 -
> {noformat}
> {noformat}
> routerB
> Router Links
> type dir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> ================================================================================================================================================================================
> inter-router in 1 3
> 250 0 0 0 83 0 0 0 0 22 0 4 0
> 0 250 -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
