[
https://issues.apache.org/jira/browse/DISPATCH-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019664#comment-17019664
]
ASF GitHub Bot commented on DISPATCH-1551:
------------------------------------------
codecov-io commented on issue #667: DISPATCH-1551 - Assure that differential
MAUs are expected before acc…
URL: https://github.com/apache/qpid-dispatch/pull/667#issuecomment-576372238
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=h1)
Report
> Merging
[#667](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/0e4c8d8bd6a66b1f0c5dab2e1c6bb19c59f2933c?src=pr&el=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 86.83% 86.87% +0.04%
==========================================
Files 92 92
Lines 21027 21032 +5
==========================================
+ Hits 18258 18271 +13
+ Misses 2769 2761 -8
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=)
| `94.84% <100%> (+0.06%)` | :arrow_up: |
|
[src/router\_core/agent\_address.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2FkZHJlc3MuYw==)
| `88.18% <0%> (-1.58%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.41% <0%> (-0.49%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.8% <0%> (-0.23%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.69% <0%> (-0.23%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.12% <0%> (-0.12%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.35% <0%> (+0.18%)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `90.22% <0%> (+0.56%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `95.17% <0%> (+0.68%)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/667/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.57% <0%> (+1.75%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=footer).
Last update
[0e4c8d8...d9a4077](https://codecov.io/gh/apache/qpid-dispatch/pull/667?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Mobile addresses can get out of sync (DISPATCH-1532 regression)
> ---------------------------------------------------------------
>
> Key: DISPATCH-1551
> URL: https://issues.apache.org/jira/browse/DISPATCH-1551
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Routing Engine
> Affects Versions: 1.11.0
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.11.0
>
>
> There's a defect in the new implementation of mobile-address-sync
> (DISPATCH-1532) that can cause a router to accept a differential update (MAU)
> when that update is not one sequence value ahead of the current state. In
> this case, the updated deltas are not applied to a known base state and can
> result in incorrect final state.
> This defect does not exist in version 1.10.0 nor any other released version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
