[
https://issues.apache.org/jira/browse/DISPATCH-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019704#comment-17019704
]
ASF GitHub Bot commented on DISPATCH-1509:
------------------------------------------
ganeshmurthy commented on pull request #668: DISPATCH-1509: free core agent
timer on shutdown
URL: https://github.com/apache/qpid-dispatch/pull/668#discussion_r368701027
##########
File path: src/router_core/router_core_private.h
##########
@@ -800,15 +801,7 @@ struct qdr_core_t {
qdrc_attach_addr_lookup_t addr_lookup_handler;
void *addr_lookup_context;
- //
- // Agent section
- //
- qdr_query_list_t outgoing_query_list;
- sys_mutex_t *query_lock;
- qd_timer_t *agent_timer;
- qdr_manage_response_t agent_response_handler;
- qdr_subscription_t *agent_subscription_mobile;
- qdr_subscription_t *agent_subscription_local;
+ qdr_agent_t *agent;
Review comment:
I wonder if this should be mgmt_agent instead of just agent because it is
used to respond exclusively to management requests coming in on $management
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Leak of core agent timer
> ------------------------
>
> Key: DISPATCH-1509
> URL: https://issues.apache.org/jira/browse/DISPATCH-1509
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.9.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Trivial
> Fix For: 1.11.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
