[
https://issues.apache.org/jira/browse/PROTON-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981706#comment-16981706
]
Jiri Daněk edited comment on PROTON-2145 at 1/21/20 8:40 AM:
-------------------------------------------------------------
I wont be trying this this today, whether any of my comments are relevant, but
I feel suspicious about some of the compile options used.
First, {{DBUILD_WITH_CXX=ON}}. That option means "use c+= compiler to build c
sources, in addition to cpp sources" and is used to workaround lack of c99
support in old visual studio. It does not mean "build me cpp binding".
Lastly {{DBUILD_TESTING=OFF}} should disable fuzz tests, if it doesn't then
this needs to be fixed.
Also, i dont like "DSYSINSTALL_BINDINGS=ON" because nobody uses it, and it
should be a noop regarding cpp binding anyways.
I had some problems with {{DBUILD_WITH_CXX=ON}} on Friday, but I don't remember
now if it was just clang related (options for clang ended up wrong and it
failed due to -Werror), or if it was anything more serious.
was (Author: jdanek):
I wont be trying this this today, whether any of my comments are relevant, but
I feel suspicious about some of the compile options used.
First, {{DBUILD_WITH_CXX=ON}}. That option means "use c+= compiler to build c
sources, in addition to cpp sources" and is used to workaround lack of c99
support in old visual studio. It does not mean "build me cop binding".
Lastly {{DBUILD_TESTING=OFF}} should disable fuzz tests, if it doesn't then
this needs to be fixed.
Also, i dont like "DSYSINSTALL_BINDINGS=ON" because nobody uses it, and it
should be a noop regarding cop binding anyways.
I had some problems with {{DBUILD_WITH_CXX=ON}} on Friday, but I don't remember
now if it was just clang related (options for clang ended up wrong and it
failed due to -Werror), or if it was anything more serious.
> libqpid-proton-cpp-static.a not included in make install
> --------------------------------------------------------
>
> Key: PROTON-2145
> URL: https://issues.apache.org/jira/browse/PROTON-2145
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Affects Versions: proton-c-0.29.0
> Environment: Linux raspberrypi 4.19.75-v7l+ #1270 SMP Tue Sep 24
> 18:51:41 BST 2019 armv7l GNU/Linux
> cmake version 3.13.4
> Reporter: berge2007
> Assignee: Gordon Sim
> Priority: Major
> Labels: build
> Fix For: proton-c-0.30.0
>
> Attachments: qpidbuild.txt
>
>
> +After these steps:+
> {{git clone [https://github.com/apache/qpid-proton.git]}}
> {{cd qpid-proton}}
> {{git checkout 0.29.0}}
> {{mkdir _build}}
> {{cd _build}}
> cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local\
> -DSYSINSTALL_BINDINGS=ON\
> -DBUILD_STATIC_LIBS=ON\
> -DBUILD_TESTING=OFF\
> -DBUILD_WITH_CXX=ON\
> -DENABLE_FUZZ_TESTING=OFF\
> -DFUZZ_REGRESSION_TESTS=OFF\
> {{make -j4}}
> {{make install}}
> +installed files in "/usr/local/lib" folder are:+
> {{/usr/local/lib/libqpid-proton-core.so}}
> {{/usr/local/lib/libqpid-proton-core.so.10}}
> {{/usr/local/lib/libqpid-proton-core.so.10.7.1}}
> {{/usr/local/lib/libqpid-proton-core-static.a}}
> {{/usr/local/lib/libqpid-proton-cpp.so}}
> {{/usr/local/lib/libqpid-proton-cpp.so.12}}
> {{/usr/local/lib/libqpid-proton-cpp.so.12.6.0}}
> {{/usr/local/lib/libqpid-proton-proactor.so}}
> {{/usr/local/lib/libqpid-proton-proactor.so.1}}
> {{/usr/local/lib/libqpid-proton-proactor.so.1.4.1}}
> {{/usr/local/lib/libqpid-proton-proactor-static.a}}
> {{/usr/local/lib/libqpid-proton.so}}
> {{/usr/local/lib/libqpid-proton.so.11}}
> {{/usr/local/lib/libqpid-proton.so.11.8.1}}
> {{/usr/local/lib/libqpid-proton-static.a}}
> so the "libqpid-proton-cpp-static.a" is missing despite that
> "DBUILD_STATIC_LIBS=ON" option
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
