[
https://issues.apache.org/jira/browse/DISPATCH-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023073#comment-17023073
]
ASF GitHub Bot commented on DISPATCH-1553:
------------------------------------------
codecov-io commented on issue #674: DISPATCH-1553: disallow problematic
characters in router.id attribute
URL: https://github.com/apache/qpid-dispatch/pull/674#issuecomment-578200966
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/674?src=pr&el=h1)
Report
> Merging
[#674](https://codecov.io/gh/apache/qpid-dispatch/pull/674?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/800bec7c0c123c96e637c3c0b75c354be6423fcc?src=pr&el=desc)
will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/674?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #674 +/- ##
=========================================
- Coverage 86.88% 86.8% -0.08%
=========================================
Files 92 92
Lines 21046 21046
=========================================
- Hits 18286 18270 -16
- Misses 2760 2776 +16
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/674?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `84.73% <0%> (-1.77%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `79.94% <0%> (-0.59%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `89.66% <0%> (-0.57%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `94.48% <0%> (-0.23%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.8% <0%> (-0.23%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.17% <0%> (-0.19%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.12% <0%> (-0.12%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/674/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.8% <0%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/674?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/674?src=pr&el=footer).
Last update
[800bec7...ca682a2](https://codecov.io/gh/apache/qpid-dispatch/pull/674?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Router ID text name is not restricted
> -------------------------------------
>
> Key: DISPATCH-1553
> URL: https://issues.apache.org/jira/browse/DISPATCH-1553
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Affects Versions: 1.10.0
> Reporter: Charles E. Rolke
> Priority: Major
>
> The router allows unicode, punctuation, and escaped characters in the Router
> ID attribute string. It is possible to construct an ID that becomes
> python-escaped when displayed in qdstat and log files. The output is
> confusing to read and hard to consume with automated tools since the strings
> are different in a) the config file, b) over the wire between routers, and c)
> in qdstat and logs.
> The proposal here is to limit the characters allowed in a Router ID to the
> following printable ASCII characters:
> * A-Z - uppercase letters
> * a-z - lowercase letters
> * 0-9 - numeric digits
> * '-' - hyphen
> * '.' - period
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
