[ 
https://issues.apache.org/jira/browse/DISPATCH-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024667#comment-17024667
 ] 

ASF GitHub Bot commented on DISPATCH-1558:
------------------------------------------

codecov-io commented on issue #675: DISPATCH-1558: Introduced a new logging 
module called PROTOCOL
URL: https://github.com/apache/qpid-dispatch/pull/675#issuecomment-578953695
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/675?src=pr&el=h1) 
Report
   > Merging 
[#675](https://codecov.io/gh/apache/qpid-dispatch/pull/675?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/f1bfb3dd010b3919c2ef06c9d2035e6189ea7b6d?src=pr&el=desc)
 will **decrease** coverage by `0.05%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/675/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/675?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #675      +/-   ##
   ==========================================
   - Coverage   86.88%   86.82%   -0.06%     
   ==========================================
     Files          92       92              
     Lines       21045    21047       +2     
   ==========================================
   - Hits        18284    18275       -9     
   - Misses       2761     2772      +11
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/675?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
 | `86.63% <100%> (+0.01%)` | :arrow_up: |
   | 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `84.73% <0%> (-1.77%)` | :arrow_down: |
   | 
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
 | `94.02% <0%> (-1.15%)` | :arrow_down: |
   | 
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
 | `89.66% <0%> (-0.57%)` | :arrow_down: |
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `93.41% <0%> (-0.49%)` | :arrow_down: |
   | 
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
 | `87.8% <0%> (-0.23%)` | :arrow_down: |
   | 
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
 | `82.16% <0%> (-0.19%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `93.24% <0%> (ø)` | :arrow_up: |
   | 
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
 | `89.36% <0%> (+0.01%)` | :arrow_up: |
   | 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `94.02% <0%> (+0.22%)` | :arrow_up: |
   | ... and [2 
more](https://codecov.io/gh/apache/qpid-dispatch/pull/675/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/675?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/675?src=pr&el=footer).
 Last update 
[f1bfb3d...2093e84](https://codecov.io/gh/apache/qpid-dispatch/pull/675?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add a new logging module called PROTOCOL 
> -----------------------------------------
>
>                 Key: DISPATCH-1558
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1558
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.10.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.11.0
>
>
> In several cases it is necessary to just log the amqp protocol trace only. 
> When the protocol level is set up to trace+ both the protocol trace and the 
> router trace statements are turned on. This new logging level will turn on 
> only the proton amqp protocol trace and not the router trace



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to