[ 
https://issues.apache.org/jira/browse/DISPATCH-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036446#comment-17036446
 ] 

ASF GitHub Bot commented on DISPATCH-1562:
------------------------------------------

ganeshmurthy commented on issue #683: DISPATCH-1562: Changed the names of 
prometheus metrics to be in line …
URL: https://github.com/apache/qpid-dispatch/pull/683#issuecomment-585927652
 
 
   Naming rules are here - https://prometheus.io/docs/practices/naming/
   
   Please take a look and let me know if you don't agree with any names that I 
came up with. @lulf has approved these changes.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make attribute names provided to Prometheus more router specific
> ----------------------------------------------------------------
>
>                 Key: DISPATCH-1562
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1562
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.10.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> Some of the attribute names used here are too generic -
> [https://github.com/apache/qpid-dispatch/blob/1.10.0/src/http-libwebsockets.c#L478]
>  
> Make them more router specific so they can be easily distinguished from other 
> metrics that come from other systems.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to