[ 
https://issues.apache.org/jira/browse/PROTON-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049263#comment-17049263
 ] 

ASF GitHub Bot commented on PROTON-2184:
----------------------------------------

kgiusti commented on issue #230: PROTON-2184: fix assert in 
pn_session_set_context
URL: https://github.com/apache/qpid-proton/pull/230#issuecomment-593434454
 
 
   Did a quick lookover the use of assert in the engine code - LGTM!
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> pn_session_set_context() aborts if zero is passed as the context
> ----------------------------------------------------------------
>
>                 Key: PROTON-2184
>                 URL: https://issues.apache.org/jira/browse/PROTON-2184
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: proton-c-0.30.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>             Fix For: proton-c-0.31.0
>
>         Attachments: 
> 0001-PROTON-2184-fix-assert-in-pn_session_set_context.patch
>
>
> This prevents the application from clearing the session context.
> Looks like the assert is wrong:
>  
> void pn_session_set_context(pn_session_t *session, void *context)
> {
>  assert(context);
> ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to