[
https://issues.apache.org/jira/browse/DISPATCH-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050570#comment-17050570
]
ASF GitHub Bot commented on DISPATCH-975:
-----------------------------------------
kgiusti commented on pull request #694: DISPATCH-975: Enforce max message size
on message ingress
URL: https://github.com/apache/qpid-dispatch/pull/694#discussion_r387298367
##########
File path: src/router_node.c
##########
@@ -329,12 +330,33 @@ static bool AMQP_rx_handler(void* context, qd_link_t
*link)
qdr_delivery_t *delivery = qdr_node_delivery_qdr_from_pn(pnd);
bool next_delivery = false;
- //
- // Receive the message into a local representation.
- //
qd_message_t *msg = qd_message_receive(pnd);
+
+ int oversize = qd_message_exceeded_max_message_size(msg);
+ if (oversize > 0) {
+ // message is bigger than maxMessageSize
+ if (oversize == 1) {
Review comment:
Q: what if the message is large and was forwarded to the core, then the
oversize condition is hit on a later transfer? Won't there be a qdr_delivery_t
outstanding on the core's qdr_link_t undelivered list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Policy has no provision for limiting user message size
> ------------------------------------------------------
>
> Key: DISPATCH-975
> URL: https://issues.apache.org/jira/browse/DISPATCH-975
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: Charles E. Rolke
> Assignee: Charles E. Rolke
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
