[
https://issues.apache.org/jira/browse/DISPATCH-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065000#comment-17065000
]
ASF GitHub Bot commented on DISPATCH-1490:
------------------------------------------
bhardesty commented on pull request #708: DISPATCH-1490 - remove old-user-guide
dir
URL: https://github.com/apache/qpid-dispatch/pull/708#discussion_r396666373
##########
File path: docs/books/CMakeLists.txt
##########
@@ -34,16 +33,10 @@ if (ASCIIDOCTOR_EXE)
execute_process (
COMMAND ${CMAKE_COMMAND} -E copy_if_different
${CMAKE_CURRENT_SOURCE_DIR}/${file}
- ${CMAKE_CURRENT_BINARY_DIR}/${file}
+ ${CMAKE_CURRENT_BINARY_DIR}/user-guide/${file}
Review comment:
@ganeshmurthy can you please verify this? Currently, if you run "make docs",
the images in user-guide/index.html are all broken. This is because the images/
dir is created one level up from where index.html expects it to be. This just
ensures that the images/ dir is created where index.html expects.
With this change, when I run "make docs", the images are in the correct
location and they all show up in the doc as they should. However, I'm not sure
if this change affects any of the make tooling for updating the website and/or
creating new qpid-dispatch releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> remove old-user-guide dir from docs source
> ------------------------------------------
>
> Key: DISPATCH-1490
> URL: https://issues.apache.org/jira/browse/DISPATCH-1490
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Documentation
> Affects Versions: 1.9.0
> Reporter: Robbie Gemmell
> Assignee: Ben Hardesty
> Priority: Minor
> Fix For: 1.12.0
>
>
> Split out from DISPATCH-1482.
> There is an old-user-guide dir in the docs tree that is essentially unused.
> Its contents are not put on the website. Both old-user-guide and the newer
> user-guide dirs have symlinks to a shared images dir kept alongside them in
> the parent dir. This caused some issues with the site (see DISPATCH-1482),
> and the build output (see DISPATCH-1489). As its been some time since the
> content was replaced, it seems overdue to delete it. Folks needing to refer
> to it can always find it in past releases source or the related website pages
> it applied fto.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
