[
https://issues.apache.org/jira/browse/PROTON-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077908#comment-17077908
]
ASF GitHub Bot commented on PROTON-1675:
----------------------------------------
jiridanek commented on pull request #238: PROTON-1675 [cpp] Attempt to listen
on invalid URL will not throw exception
URL: https://github.com/apache/qpid-proton/pull/238
Calling listen() with invalid address is not supposed to throw a C++
exception, it is supposed end up calling the `on_error` callback. So let's
remove the try catch blocks from the test, since there aren't any expected
exceptions here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] Attempt to listen on invalid URL will not throw exception
> ---------------------------------------------------------------
>
> Key: PROTON-1675
> URL: https://issues.apache.org/jira/browse/PROTON-1675
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Affects Versions: proton-j-0.18.0
> Reporter: Jiri Daněk
> Assignee: Clifford Jansen
> Priority: Major
>
> The test {{container_test.cpp/test_container_bad_address()}} is not checking
> that expected exceptions are actually thrown. If I add these checks, the test
> starts failing.
> {noformat}
> diff --git a/proton-c/bindings/cpp/src/container_test.cpp
> b/proton-c/bindings/cpp/src/container_test.cpp
> index eb05ddbd..d1dc6628 100644
> --- a/proton-c/bindings/cpp/src/container_test.cpp
> +++ b/proton-c/bindings/cpp/src/container_test.cpp
> @@ -176,12 +176,18 @@ int test_container_bad_address() {
>
> proton::container c;
> // Default fixed-option listener. Valgrind for leaks.
> - try { c.listen("999.666.999.666:0"); } catch (const proton::error&) {}
> + try {
> + c.listen("999.666.999.666:0");
> + FAIL("exception expected");
> + } catch (const proton::error&) {}
> c.run();
> // Dummy listener.
> test_listen_handler l;
> test_handler h2("999.999.999.666", proton::connection_options());
> - try { c.listen("999.666.999.666:0", l); } catch (const proton::error&) {}
> + try {
> + c.listen("999.666.999.666:0", l);
> + FAIL("exception expected");
> + } catch (const proton::error&) {}
> c.run();
> ASSERT(!l.on_open_);
> ASSERT(!l.on_accept_);
> {noformat}
> No exception is ever thrown: invalid IP, port is already occupied, port is <
> 1025 and I am not root... never.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
