[
https://issues.apache.org/jira/browse/DISPATCH-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085220#comment-17085220
]
ASF GitHub Bot commented on DISPATCH-1479:
------------------------------------------
bhardesty commented on pull request #720: DISPATCH-1479 - update multicast
'accepted' definition
URL: https://github.com/apache/qpid-dispatch/pull/720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> multicast/routing behaviour doc improvements
> --------------------------------------------
>
> Key: DISPATCH-1479
> URL: https://issues.apache.org/jira/browse/DISPATCH-1479
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Documentation
> Reporter: Robbie Gemmell
> Assignee: Ben Hardesty
> Priority: Minor
>
> The description of the multicast 'accepted' behaviour could be improved and
> simplified. It is currently described as:
> {noformat}
> Either:
> * All consumers received the message,
> * Or, at least one consumer received the message, but no consumers rejected
> it.
> {noformat}
> (From
> [http://qpid.apache.org/releases/qpid-dispatch-1.9.0/user-guide/index.html#message_settlement_and_reliability],
> which seems to now be sourced on master from
> [https://github.com/apache/qpid-dispatch/blob/master/docs/books/modules/user-guide/routing.adoc])
>
> The 'received the message' bit could perhaps be clearer, e.g. by changing to
> 'accepted the message' (same would also apply in the anycast column), since
> many consumers may have received but not accepted the message.
> It also feels like the either-or distinction should just be removed, leaving
> only an 'at least one' style description. I dont believe there is a way to
> discern the number of recipients that have accepted, its just known 1-n
> consumers accepted without any reject, so it seems more confusing to describe
> it as an 'either or' situation.
>
> Related, the routing.adoc file referenced above seems to be an updated
> variant covering older content from
> [https://github.com/apache/qpid-dispatch/blob/master/docs/books/modules/user-guide/message-routing.adoc]
> and
> [https://github.com/apache/qpid-dispatch/blob/master/docs/books/modules/user-guide/link-routing.adoc]
> which each say they are included in routing.adoc but dont actually appear to
> be. Their content seems stale too, so perhaps they can be deleted?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
