[
https://issues.apache.org/jira/browse/PROTON-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090140#comment-17090140
]
ASF GitHub Bot commented on PROTON-2194:
----------------------------------------
astitcher commented on issue #240:
URL: https://github.com/apache/qpid-proton/pull/240#issuecomment-618118013
This looks correct to me - I've merged it - thank for finding this issue and
giving us a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Incorrect memory deallocation
> -----------------------------
>
> Key: PROTON-2194
> URL: https://issues.apache.org/jira/browse/PROTON-2194
> Project: Qpid Proton
> Issue Type: Bug
> Reporter: Attila Kun
> Priority: Major
> Attachments: schannel_exception.png
>
>
> When execution gets to {{server_name_matches}} in {{schannel.c}}, an attempt
> is made to deallocate a chunk of memory here:
> [https://github.com/apache/qpid-proton/blob/0.30.0/c/src/ssl/schannel.c#L2078]
> However, this is incorrect because the code is passing the pointer's address
> (which is a memory location on the stack, not the heap) to {{LocalFree}} .
> This causes a crash. The fix is simply to pass the pointer's value:
> [https://github.com/attila-kun/qpid-proton/commit/21e88fe0b18a4587768b16ae275a8ae88fd919bb]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
