[
https://issues.apache.org/jira/browse/DISPATCH-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095531#comment-17095531
]
Robbie Gemmell commented on DISPATCH-1631:
------------------------------------------
Ill admit I cant remember whether I sourced config.sh or not - but even if i
didn't it still seems odd only those 2 tests would fail, and either way they
did so by looking for files in the install dir and then passed as soon as it
was installed.
My testing would have been as follows:
{noformat}
mkdir build
cd build
cmake .. -DCMAKE_INSTALL_PREFIX=`pwd`/install
<may or may not have sourced config.sh>
make -j4
ctest -V -R
{noformat}
> system_tests_bad_configuration fails if the router is not already installed
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-1631
> URL: https://issues.apache.org/jira/browse/DISPATCH-1631
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.12.0
> Reporter: Robbie Gemmell
> Assignee: Charles E. Rolke
> Priority: Major
>
> _test_verify_reject_id_with_ctrl_char_ and
> _test_verify_reject_id_with_whitespace_ from _system_tests_bad_configuration_
> fail unless the router is already installed, which is annoying given it is
> typical to test before installing.
> If the tests do need an install for some reason they could perhaps verify one
> exists which works with good config, rather than fail because one doesnt
> exist.
> I have noted similar issues with tests in the past, which seems to point to a
> change needed in the CI to actually catch such things as they happen.
> {noformat}
> Start 51: system_tests_bad_configuration
> 51: Test command: /usr/bin/python
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_bad_configuration"
> 51: Test timeout computed to be: 600
> 51: test_qdmanage_query
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51: test_unresolvable_host_caught
> (system_tests_bad_configuration.RouterTestBadConfiguration) ... ok
> 51:
> 51: Router QDR.A debug dump file:
> 51: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> 51: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> 51: test_verify_reject_id_with_ctrl_char
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar) ... FAIL
> 51: test_verify_reject_id_with_whitespace
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace) ... FAIL
> 51:
> 51: ======================================================================
> 51: FAIL: test_verify_reject_id_with_ctrl_char
> (system_tests_bad_configuration.RouterTestIdFailCtrlChar)
> 51: ----------------------------------------------------------------------
> 51: Traceback (most recent call last):
> 51: File
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
> line 203, in test_verify_reject_id_with_ctrl_char
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51:
> 51: ======================================================================
> 51: FAIL: test_verify_reject_id_with_whitespace
> (system_tests_bad_configuration.RouterTestIdFailWhiteSpace)
> 51: ----------------------------------------------------------------------
> 51: Traceback (most recent call last):
> 51: File
> "/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/tests/system_tests_bad_configuration.py",
> line 243, in test_verify_reject_id_with_whitespace
> 51: assert False, "AttributeError not in process output"
> 51: AssertionError: AttributeError not in process output
> 51:
> 51: ----------------------------------------------------------------------
> 51: Ran 4 tests in 1.293s
> 51:
> 51: FAILED (failures=2)
> 51: output: 2020-04-28 09:57:22.734890 +0100 ERROR (error) Cannot find Python
> library path
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
> Unknown error 2
> 51: qdrouterd: Cannot find Python library path
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
> Unknown error 2
> 51:
> 51: output: 2020-04-28 09:57:22.838318 +0100 ERROR (error) Cannot find Python
> library path
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
> Unknown error 2
> 51: qdrouterd: Cannot find Python library path
> '/path/to/testing/dispatch/1.12.0-rc1/qpid-dispatch-1.12.0/build/install/lib/qpid-dispatch/python':
> Unknown error 2
> 51:
> 1/1 Test #51: system_tests_bad_configuration ...***Failed 1.35 sec
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
