[
https://issues.apache.org/jira/browse/DISPATCH-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101720#comment-17101720
]
ASF GitHub Bot commented on DISPATCH-1636:
------------------------------------------
kgiusti commented on a change in pull request #730:
URL: https://github.com/apache/qpid-dispatch/pull/730#discussion_r421551362
##########
File path: include/qpid/dispatch/router_core.h
##########
@@ -851,6 +851,30 @@ void qdr_query_free(qdr_query_t *query);
typedef void (*qdr_manage_response_t) (void *context, const qd_amqp_error_t
*status, bool more);
void qdr_manage_handler(qdr_core_t *core, qdr_manage_response_t
response_handler);
+typedef struct {
+ uint16_t major;
+ uint16_t minor;
+ uint16_t patch;
+ uint16_t flags;
+#define QDR_ROUTER_VERSION_SNAPSHOT 0x0100
+#define QDR_ROUTER_VERSION_RC 0x0200 // lower byte == RC #
Review comment:
Nope - not yet. Reserved. Since we _do_ use a snapshot (dev builds), I
wanted to add an additional flag to the version, which - since it's 2 bytes -
aligns the version structure to a nice round 8 bytes and gives us a few extra
bits to support RC numbers if we ever choose to do so in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Extract the version advertized in the Open performative by the peer router
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-1636
> URL: https://issues.apache.org/jira/browse/DISPATCH-1636
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Affects Versions: 1.12.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Trivial
> Fix For: 1.13.0
>
>
> Cache the version in the qdr_connection_info to use for backward
> compatibility checking.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
