[ 
https://issues.apache.org/jira/browse/PROTON-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101723#comment-17101723
 ] 

ASF subversion and git services commented on PROTON-2211:
---------------------------------------------------------

Commit 9e1fff5f7998fcb171c958c10a84d72b4df7eb93 in qpid-proton's branch 
refs/heads/master from Clifford Jansen
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=9e1fff5 ]

PROTON-2211: fix fd leak on connections in new epoll proactor implementation


> Epoll proactor leaks file descriptors
> -------------------------------------
>
>                 Key: PROTON-2211
>                 URL: https://issues.apache.org/jira/browse/PROTON-2211
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: proton-c-0.31.0
>            Reporter: Clifford Jansen
>            Assignee: Clifford Jansen
>            Priority: Blocker
>             Fix For: proton-c-0.31.0
>
>
> Separation of responsibility of closing a file descriptor (which could 
> generate an event) and registering/deregistering it within epoll (to watch 
> for or ignore events) was strong in the previous proactor version. 
> Rationalizing the data structures for space efficiency and overall clarity 
> obscured this in the new version, and the removal of a "duplicate" fd 
> reference made it possible to forget the fd to close.
> From inspection, a simple short term fix is to remember the fd that is being 
> leaked and close it when suitable.
> The longer term fix should perhaps rationalize the current async nature of 
> start_polling() and stop_polling() and serialize it through the new scheduler 
> mechanism in the newer epoll proactor implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to