[jira] [Commented] (PROTON-2215) Windows build fails if CMAKE_MODULE_PATH is not empty

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/PROTON-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109431#comment-17109431
 ] 

ASF GitHub Bot commented on PROTON-2215:
----------------------------------------

codecov-io edited a comment on pull request #141:
URL: https://github.com/apache/qpid-proton/pull/141#issuecomment-380504872


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/141?src=pr&el=h1) 
Report
   > Merging 
[#141](https://codecov.io/gh/apache/qpid-proton/pull/141?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-proton/commit/7abcfc7aba6cfd1c938324cf34a51555c845a589&el=desc)
 will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-proton/pull/141/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/141?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #141      +/-   ##
   ==========================================
   - Coverage   81.57%   81.56%   -0.01%     
   ==========================================
     Files         270      270              
     Lines       36434    36439       +5     
   ==========================================
   + Hits        29722    29723       +1     
   - Misses       6712     6716       +4     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-proton/pull/141?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/141/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j)
 | `82.37% <0.00%> (-0.24%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/141?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/141?src=pr&el=footer). 
Last update 
[7abcfc7...6376e26](https://codecov.io/gh/apache/qpid-proton/pull/141?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Windows build fails if CMAKE_MODULE_PATH is not empty
> -----------------------------------------------------
>
>                 Key: PROTON-2215
>                 URL: https://issues.apache.org/jira/browse/PROTON-2215
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: build
>    Affects Versions: proton-c-0.31.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>              Labels: windows
>             Fix For: proton-c-0.32.0
>
>
> In {{tools/cmake/Modules/WindowsC99CheckDef.cmake}}:
> {code}
> COMMAND ${PYTHON_EXECUTABLE}
>           ${CMAKE_MODULE_PATH}/WindowsC99SymbolCheck.py 
> $<TARGET_FILE_DIR:qpid-proton>
> {code}
> This is wrong, if only because {{CMAKE_MODULE_PATH}} is a list of 
> directories, not a single directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org