[
https://issues.apache.org/jira/browse/DISPATCH-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113306#comment-17113306
]
ASF GitHub Bot commented on DISPATCH-1646:
------------------------------------------
codecov-commenter edited a comment on pull request #740:
URL: https://github.com/apache/qpid-dispatch/pull/740#issuecomment-631096810
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/740?src=pr&el=h1)
Report
> Merging
[#740](https://codecov.io/gh/apache/qpid-dispatch/pull/740?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/04e69505d54b0c14ea7950c070c1af185df07b7d&el=desc)
will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/740?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
- Coverage 87.02% 86.96% -0.07%
==========================================
Files 96 96
Lines 21714 21728 +14
==========================================
- Hits 18897 18895 -2
- Misses 2817 2833 +16
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/740?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j)
| `91.24% <0.00%> (-0.35%)` | :arrow_down: |
|
[src/http-none.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL2h0dHAtbm9uZS5j)
| `62.50% <0.00%> (-8.93%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `91.78% <0.00%> (-1.25%)` | :arrow_down: |
|
[src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j)
| `91.54% <0.00%> (-0.50%)` | :arrow_down: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.80% <0.00%> (-0.23%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `90.90% <0.00%> (-0.19%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.17% <0.00%> (-0.17%)` | :arrow_down: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `85.22% <0.00%> (-0.12%)` | :arrow_down: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `91.39% <0.00%> (+0.09%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.23% <0.00%> (+0.48%)` | :arrow_up: |
| ... and [1
more](https://codecov.io/gh/apache/qpid-dispatch/pull/740/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/740?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/740?src=pr&el=footer).
Last update
[d02a246...09190b5](https://codecov.io/gh/apache/qpid-dispatch/pull/740?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unable to delete listener with http enabled
> -------------------------------------------
>
> Key: DISPATCH-1646
> URL: https://issues.apache.org/jira/browse/DISPATCH-1646
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Ulf Lilleengen
> Assignee: Ganesh Murthy
> Priority: Major
>
> I'm running into an issue when trying to delete a listener which has 'http:
> true' set. The router returns the error message "HTTP listeners cannot be
> deleted". I can see that there is a test for this in the router code as well.
> However, in order for EnMasse to be able to create and delete listeners that
> are used to handle websocket connections for different tenants, we need a way
> to delete listeners with http: true set through AMQP management without
> restarting the router.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
