[
https://issues.apache.org/jira/browse/PROTON-2220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113545#comment-17113545
]
ASF GitHub Bot commented on PROTON-2220:
----------------------------------------
codecov-commenter commented on pull request #248:
URL: https://github.com/apache/qpid-proton/pull/248#issuecomment-632350815
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/248?src=pr&el=h1)
Report
> Merging
[#248](https://codecov.io/gh/apache/qpid-proton/pull/248?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/7f86fa4eb261fad7ade33f62acf3d2ce115e9497&el=desc)
will **decrease** coverage by `4.02%`.
> The diff coverage is `88.47%`.
[](https://codecov.io/gh/apache/qpid-proton/pull/248?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 81.56% 77.54% -4.03%
==========================================
Files 270 259 -11
Lines 36439 31131 -5308
==========================================
- Hits 29722 24139 -5583
- Misses 6717 6992 +275
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/248?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[python/proton/\_transport.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9fdHJhbnNwb3J0LnB5)
| `67.54% <ø> (-23.61%)` | :arrow_down: |
|
[tests/py/test\_unittest.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-dGVzdHMvcHkvdGVzdF91bml0dGVzdC5weQ==)
| `21.05% <14.28%> (ø)` | |
|
[...on/test\_PROTON\_1800\_syncrequestresponse\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE4MDBfc3luY3JlcXVlc3RyZXNwb25zZV9mZF9sZWFrLnB5)
| `92.50% <92.50%> (ø)` | |
|
[...PROTON\_2111\_container\_ssl\_ssldomain\_object\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzIxMTFfY29udGFpbmVyX3NzbF9zc2xkb21haW5fb2JqZWN0X2xlYWsucHk=)
| `93.00% <93.00%> (ø)` | |
|
[...est\_PROTON\_2116\_blocking\_connection\_object\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzIxMTZfYmxvY2tpbmdfY29ubmVjdGlvbl9vYmplY3RfbGVhay5weQ==)
| `94.05% <94.05%> (ø)` | |
|
[...on/test\_PROTON\_2121\_blocking\_connection\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzIxMjFfYmxvY2tpbmdfY29ubmVjdGlvbl9mZF9sZWFrLnB5)
| `95.74% <95.74%> (ø)` | |
|
[python/proton/\_reactor.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9fcmVhY3Rvci5weQ==)
| `64.12% <100.00%> (-13.93%)` | :arrow_down: |
|
[.../test\_PROTON\_1709\_application\_event\_object\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE3MDlfYXBwbGljYXRpb25fZXZlbnRfb2JqZWN0X2xlYWsucHk=)
| `100.00% <100.00%> (ø)` | |
|
[python/proton/\_data.py](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9fZGF0YS5weQ==)
| `50.70% <0.00%> (-38.88%)` | :arrow_down: |
| ... and [38
more](https://codecov.io/gh/apache/qpid-proton/pull/248/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/248?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/248?src=pr&el=footer).
Last update
[7f86fa4...18f7b15](https://codecov.io/gh/apache/qpid-proton/pull/248?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add tests for recently fixed leaks in Python binding
> ----------------------------------------------------
>
> Key: PROTON-2220
> URL: https://issues.apache.org/jira/browse/PROTON-2220
> Project: Qpid Proton
> Issue Type: Test
> Components: python-binding
> Affects Versions: proton-c-0.31.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.32.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
