[
https://issues.apache.org/jira/browse/DISPATCH-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117362#comment-17117362
]
ASF GitHub Bot commented on DISPATCH-1656:
------------------------------------------
codecov-commenter commented on pull request #746:
URL: https://github.com/apache/qpid-dispatch/pull/746#issuecomment-634197090
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr&el=h1)
Report
> Merging
[#746](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/be42638a2da2d9fec0fac98f3b1c1be1606002c0&el=desc)
will **decrease** coverage by `0.32%`.
> The diff coverage is `50.24%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 86.95% 86.63% -0.33%
==========================================
Files 96 96
Lines 21728 21930 +202
==========================================
+ Hits 18894 18999 +105
- Misses 2834 2931 +97
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/compose.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL2NvbXBvc2UuYw==)
| `88.02% <0.00%> (-1.58%)` | :arrow_down: |
|
[src/proton\_utils.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL3Byb3Rvbl91dGlscy5j)
| `48.96% <38.29%> (-19.67%)` | :arrow_down: |
|
[src/entity.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL2VudGl0eS5j)
| `56.75% <57.14%> (+0.06%)` | :arrow_up: |
|
[src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j)
| `75.22% <57.35%> (-2.44%)` | :arrow_down: |
|
[src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j)
| `91.26% <100.00%> (+0.01%)` | :arrow_up: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.36% <100.00%> (+0.20%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.31% <0.00%> (-0.17%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `91.68% <0.00%> (-0.11%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.47% <0.00%> (+0.10%)` | :arrow_up: |
| ... and [1
more](https://codecov.io/gh/apache/qpid-dispatch/pull/746/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr&el=footer).
Last update
[be42638...0bff301](https://codecov.io/gh/apache/qpid-dispatch/pull/746?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow user-configured connection properties in the Open performative
> --------------------------------------------------------------------
>
> Key: DISPATCH-1656
> URL: https://issues.apache.org/jira/browse/DISPATCH-1656
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.13.0
>
>
> This feature would add a new "openProperties" attribute to the
> org.apache.qpid.dispatch.connector and org.apache.qpid.dispatch.listener
> management entities. This new attribute is type string and is optional.
> If supplied it will consist of a series of one or more field entries
> separated by commas. A field entry is text in the form "key: value", where
> "key" that can be encoded as a valid AMQP 1.0 Symbol type. Value will be
> encoded as an AMQP 1.0 String type.
> The key or value text may contain spaces, colons or commas but must be
> enclosed in single quotes (see example below) if it does.
> Duplicate keys are NOT allowed.
> Key values that start with *qd.* or *x-opt-qd.* are reserved and must not be
> used.
> In addition, the following keys are reserved and must not be used:
> product
> version
> failover-server-list
> network-host
> port
> scheme
> hostname
> The openProperties keys and values will be merged into the connection
> properties field of the outgoing Open performative when establishing or
> accepting connections.
> The openProperties attribute is NOT allowed on connector or listener entities
> with roles of either "inter-router" or "edge".
> The openProperties attribute is NOT allowed on listener entities than enable
> http, i.e. http: true.
> Example:
> {{connector {}}
> {{ name: broker}}
> {{ role: route-container}}
> {{ host: 127.0.0.1}}
> {{ port: 22180}}
> {{ saslMechanisms: ANONYMOUS}}
> {{ *openProperties: "foo: bar,baz:foo, bar: 'Hello: you big, wonderful
> world!'"*}}
> {{}}}
>
> The resulting connection properties in the outgoing Open performative would
> include the following map entries:
> {{Symbol(foo): String(bar),}}
> {{Symbol(baz): String(foo),}}
> {{Symbol(bar): String(Hello: you big, wonderful world!)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
