[
https://issues.apache.org/jira/browse/PROTON-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123465#comment-17123465
]
ASF GitHub Bot commented on PROTON-1800:
----------------------------------------
codecov-commenter edited a comment on pull request #253:
URL: https://github.com/apache/qpid-proton/pull/253#issuecomment-637360331
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=h1)
Report
> Merging
[#253](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/b34bbea0e34901b8e25b1c74715fcc5a5229ad65&el=desc)
will **increase** coverage by `0.00%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 83.09% 83.09%
=======================================
Files 339 339
Lines 41362 41368 +6
=======================================
+ Hits 34368 34373 +5
- Misses 6994 6995 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[...on/test\_PROTON\_1800\_syncrequestresponse\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE4MDBfc3luY3JlcXVlc3RyZXNwb25zZV9mZF9sZWFrLnB5)
| `91.20% <81.81%> (-1.30%)` | :arrow_down: |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `81.54% <0.00%> (-0.17%)` | :arrow_down: |
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.21% <0.00%> (-0.06%)` | :arrow_down: |
|
[c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/253/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j)
| `82.61% <0.00%> (+0.24%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=footer).
Last update
[b34bbea...032094a](https://codecov.io/gh/apache/qpid-proton/pull/253?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> BlockingConnection descriptor leak
> ----------------------------------
>
> Key: PROTON-1800
> URL: https://issues.apache.org/jira/browse/PROTON-1800
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.21.0
> Reporter: Andy Smith
> Assignee: Jiri Daněk
> Priority: Major
> Labels: leak, workaround
> Fix For: proton-c-future
>
> Attachments: sync_client.py
>
>
> Modified collectd python plugin from using persistent connection to
> connection per read. Following change, detected descriptor leak.
> Attached modification to sync_client.py exhibits the issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
