[
https://issues.apache.org/jira/browse/PROTON-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124213#comment-17124213
]
ASF GitHub Bot commented on PROTON-2237:
----------------------------------------
codecov-commenter edited a comment on pull request #256:
URL: https://github.com/apache/qpid-proton/pull/256#issuecomment-637742528
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/256?src=pr&el=h1)
Report
> Merging
[#256](https://codecov.io/gh/apache/qpid-proton/pull/256?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/65a5d9e837cf8de3024e7039dc7f5f2175d13461&el=desc)
will **increase** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/qpid-proton/pull/256?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 83.05% 83.14% +0.09%
==========================================
Files 338 339 +1
Lines 41431 41521 +90
==========================================
+ Hits 34410 34523 +113
+ Misses 7021 6998 -23
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/256?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[python/proton/\_message.py](https://codecov.io/gh/apache/qpid-proton/pull/256/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9fbWVzc2FnZS5weQ==)
| `86.69% <100.00%> (ø)` | |
|
[ruby/tests/test\_interop.rb](https://codecov.io/gh/apache/qpid-proton/pull/256/diff?src=pr&el=tree#diff-cnVieS90ZXN0cy90ZXN0X2ludGVyb3AucmI=)
| `95.55% <0.00%> (ø)` | |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/256/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `82.25% <0.00%> (+0.99%)` | :arrow_up: |
|
[ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/256/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==)
| `96.10% <0.00%> (+3.89%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/256?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/256?src=pr&el=footer).
Last update
[65a5d9e...ccbfcf6](https://codecov.io/gh/apache/qpid-proton/pull/256?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [python] Non-string message property keys not handled correctly
> ---------------------------------------------------------------
>
> Key: PROTON-2237
> URL: https://issues.apache.org/jira/browse/PROTON-2237
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Reporter: Kim van der Riet
> Priority: Major
>
> The AMQP 1.0 spec allows only string keys for message properties.
> Proton's Python binding has a method (_message.py:91 _check_property_keys())
> for checking message property keys, but it does not handle all cases
> correctly:
> # Proton types Symbol and Char are derived from string, and are allowed in
> the test. This results in an illegal encoding.
> # Because in Python 2, many coders carelessly use string literals without
> the required u'' prefix (and thus results in a bytes type), bytes types are
> converted to unicode string types. However, the encode() function is being
> used, which simply returns a binary type in Python 2 and raises an error in
> Python 3. This should probably be the decode() method, which returns a string
> and works for both Python 2 and 3.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
