[
https://issues.apache.org/jira/browse/PROTON-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129580#comment-17129580
]
ASF GitHub Bot commented on PROTON-335:
---------------------------------------
codecov-commenter edited a comment on pull request #260:
URL: https://github.com/apache/qpid-proton/pull/260#issuecomment-640902944
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/260?src=pr&el=h1)
Report
> Merging
[#260](https://codecov.io/gh/apache/qpid-proton/pull/260?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/caaa9459e77a593017fe4cfdea883bd21f66bf67&el=desc)
will **decrease** coverage by `0.00%`.
> The diff coverage is `97.33%`.
[](https://codecov.io/gh/apache/qpid-proton/pull/260?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 83.15% 83.15% -0.01%
==========================================
Files 339 339
Lines 41521 41593 +72
==========================================
+ Hits 34526 34585 +59
- Misses 6995 7008 +13
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/260?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[c/src/core/transport.c](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS90cmFuc3BvcnQuYw==)
| `90.44% <80.00%> (-0.08%)` | :arrow_down: |
|
[c/src/core/engine.c](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9lbmdpbmUuYw==)
| `94.73% <100.00%> (+0.04%)` | :arrow_up: |
|
[c/tests/engine\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-Yy90ZXN0cy9lbmdpbmVfdGVzdC5jcHA=)
| `100.00% <100.00%> (ø)` | |
|
[python/proton/\_endpoints.py](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9fZW5kcG9pbnRzLnB5)
| `92.14% <100.00%> (+0.25%)` | :arrow_up: |
|
[python/tests/proton\_tests/engine.py](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy9lbmdpbmUucHk=)
| `98.36% <100.00%> (+<0.01%)` | :arrow_up: |
|
[ruby/spec/spec\_helper.rb](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-cnVieS9zcGVjL3NwZWNfaGVscGVyLnJi)
| `63.63% <0.00%> (-1.82%)` | :arrow_down: |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `81.87% <0.00%> (-0.56%)` | :arrow_down: |
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/260/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.21% <0.00%> (-0.06%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/260?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/260?src=pr&el=footer).
Last update
[caaa945...a1fdcae](https://codecov.io/gh/apache/qpid-proton/pull/260?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Need a means of specifying and reading link properties
> ------------------------------------------------------
>
> Key: PROTON-335
> URL: https://issues.apache.org/jira/browse/PROTON-335
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-0.4, proton-c-0.29.0
> Reporter: Gordon Sim
> Assignee: Ken Giusti
> Priority: Minor
> Labels: api
> Fix For: proton-c-0.32.0
>
>
> There are some cases where it may be beneficial to use link properties (since
> link capabilities do not allow for key-value pairs, they can't easily convey
> a desired configurable value and the properties on a terminus refer to the
> dynamically created node not the link or the terminus itself).
> (I've set this to minor since major feels a little strong, but I do think its
> important ultimately for the engine to expose all the extension points from
> the protocol.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
