[
https://issues.apache.org/jira/browse/PROTON-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kim van der Riet updated PROTON-2248:
-------------------------------------
Description:
The *{{pn_data_vfill()}}* method in codec.c:571 has the symbol and string types
interchanged. The function documentation states:
{noformat}
/* Format codes:
code: AMQP-type (arguments)
...
S: symbol (char*)
s: string (char*)
...
*/
{noformat}
but uses these the other way around, ie {{s}} for symbol and {{S}} for string:
{noformat}
if (code == 'S') {
err = pn_data_put_string(data, pn_bytes(size, start));
} else {
err = pn_data_put_symbol(data, pn_bytes(size, start));
}
{noformat}
Guidance is needed on whether to fix the reversal and keep the stated codes, or
reverse the codes.
was:
The *{{pn_data_vfill()}}* method in codec.c:571 has the symbol and string types
interchanged. The method documentation states:
{noformat}
/* Format codes:
code: AMQP-type (arguments)
...
S: symbol (char*)
s: string (char*)
...
*/
{noformat}
but uses these the other way around, ie {{s}} for symbol and {{S}} for string:
{noformat}
if (code == 'S') {
err = pn_data_put_string(data, pn_bytes(size, start));
} else {
err = pn_data_put_symbol(data, pn_bytes(size, start));
}
{noformat}
Guidance is needed on whether to fix the reversal and keep the stated codes, or
reverse the codes.
> [Proton-c] Codec pn_data_vfill() method has symbol and string types
> interchanged.
> ---------------------------------------------------------------------------------
>
> Key: PROTON-2248
> URL: https://issues.apache.org/jira/browse/PROTON-2248
> Project: Qpid Proton
> Issue Type: Bug
> Reporter: Kim van der Riet
> Priority: Major
>
> The *{{pn_data_vfill()}}* method in codec.c:571 has the symbol and string
> types interchanged. The function documentation states:
> {noformat}
> /* Format codes:
> code: AMQP-type (arguments)
> ...
> S: symbol (char*)
> s: string (char*)
> ...
> */
> {noformat}
> but uses these the other way around, ie {{s}} for symbol and {{S}} for string:
> {noformat}
> if (code == 'S') {
> err = pn_data_put_string(data, pn_bytes(size, start));
> } else {
> err = pn_data_put_symbol(data, pn_bytes(size, start));
> }
> {noformat}
> Guidance is needed on whether to fix the reversal and keep the stated codes,
> or reverse the codes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
