[ 
https://issues.apache.org/jira/browse/QPID-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157391#comment-17157391
 ] 

ASF GitHub Bot commented on QPID-8368:
--------------------------------------

gemmellr commented on a change in pull request #48:
URL: https://github.com/apache/qpid-broker-j/pull/48#discussion_r454373926



##########
File path: broker-plugins/logging-logback/pom.xml
##########
@@ -47,6 +47,11 @@
       <artifactId>logback-classic</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>de.siegmar</groupId>
+      <artifactId>logback-gelf</artifactId>
+    </dependency>

Review comment:
       I'll leave detailed review/discussion for those more familiar with the 
broker and its logging bits, but one key thing sticks out here that affects 
things to some extent:
   
   The logback-gelf dependency is LGPL 2.1 licensed which means it is 
considered Category X (https://www.apache.org/legal/resolved.html#category-x) 
and cant be distributed by the Qpid project, for example within the broker 
release convenience binary, or be required for the broker to operate in typical 
usage, but could potentially be used in optional functionality.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> [Broker-J] Graylog support
> --------------------------
>
>                 Key: QPID-8368
>                 URL: https://issues.apache.org/jira/browse/QPID-8368
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Tomas Vavricka
>            Priority: Major
>              Labels: logging
>             Fix For: Future
>
>
> Graylog is widely used logging service based on ElasticSearch. Qpid Broker-J 
> should support Graylog as one of Broker Loggers type.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to