[ 
https://issues.apache.org/jira/browse/QPID-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159065#comment-17159065
 ] 

Robert Godfrey commented on QPID-8454:
--------------------------------------

[~orudyy] I've not thought *hugely* about this... but my gut instinct is that 
the metric names are probably best defined as something like 
qpid_<category>_<statistic>_<suffix>.  The suffix can be constructed from the 
StatisticUnit and StatisticType, with added labels for the names of the parent 
objects...  e.g. qpid_queue_consumers_count {queue=myqueue, virtualhost=myhost 
...}.  I think we probably want to allow for the fine tuning of the prometheus 
name through annotation meta data on the statistic ( metricname="consumers" ) 
... and also maybe a way of indicating whether it should even be exposed via 
Prometheus



> [Broker-J] Expose configured object statistics in prometheus format
> -------------------------------------------------------------------
>
>                 Key: QPID-8454
>                 URL: https://issues.apache.org/jira/browse/QPID-8454
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Broker-J
>            Reporter: Alex Rudyy
>            Priority: Major
>             Fix For: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9
>
>
> The configured object statistics currently can be retrieved using a call to 
> method {{getStatistics()}}, configured object REST API endpoint 
> {{/api/latest/<category>/<path>}} or query API ( 
> {{/api/latest/querybroker/<category>}} or  {{/api/latest/queryvhost/<virtual 
> host node name>/<virtual host name>/<category>}} ). The statistics is 
> returned back to the caller in json format. That works for majority of uses 
> cases. However, when it is required to integrate Qpid Broker-J with 
> Prometheus, the Qpid users are required to implement an intermediate layer 
> where Qpid metrics needs to be converted into a Prometheus format 
> [https://prometheus.io/docs/concepts/data_model/].
> In order to easy the burden of integration Qpid Broker-J with Prometheus, the 
> support for reporting statistics metrics in Prometheus format can be added 
> into Qpid Broker-J. 
> Potentially, we can add an endpoint exposing all Qpid statistics as 
> Prometheus metrics [https://prometheus.io/docs/concepts/metric_types/]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to